Request keyframes more frequently on stream start/decoding error.

webrtc/modules/video_coding/video_receiver.cc

Index: webrtc/modules/video_coding/video_receiver.cc
diff --git a/webrtc/modules/video_coding/video_receiver.cc b/webrtc/modules/video_coding/video_receiver.cc
index 3d3e155dc3e1a6417cc5a255f5406603435a76a7..de6764f9b54e1cd23522f6d5837bf0242420dbad 100644
--- a/webrtc/modules/video_coding/video_receiver.cc
+++ b/webrtc/modules/video_coding/video_receiver.cc
@@ -320,24 +320,7 @@ int32_t VideoReceiver::Decode(const VCMEncodedFrame& frame) {
   if (decoder == nullptr) {
     return VCM_NO_CODEC_REGISTERED;
   }
-  // Decode a frame
-  int32_t ret = decoder->Decode(frame, clock_->TimeInMilliseconds());
-
-  // Check for failed decoding, run frame type request callback if needed.
-  bool request_key_frame = false;
-  if (ret < 0) {
-    request_key_frame = true;
-  }
-
-  if (!frame.Complete() || frame.MissingFrame()) {

[philipel, 2017/08/07 11:43:34]

I assume this if statement was used when we allowed decoding with artifacts.

[terelius, 2017/08/07 12:00:05]

I don't understand the purpose of this code. It would be good if someone who
does could review the change. 

[stefan-webrtc, 2017/08/07 12:24:53]

I wrote it I think. It's purpose is to request a key frame if we've decoded a
frame which is incomplete or misses references. That should no longer happen.

-    request_key_frame = true;
-    ret = VCM_OK;
-  }
-  if (request_key_frame) {
-    rtc::CritScope cs(&process_crit_);
-    _scheduleKeyRequest = true;

[stefan-webrtc, 2017/08/07 12:24:53]

Would be nice to get rid of this member eventually.

[philipel, 2017/08/07 13:30:11]

Yes, it was still used by other parts of this class, but it should be removed in
some other cleanup CL.

-  }
-  return ret;
+  return decoder->Decode(frame, clock_->TimeInMilliseconds());
 }
 
 // Register possible receive codecs, can be called multiple times