Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: webrtc/modules/video_coding/frame_object.h

Issue 2993513002: Fix off-by-one bugs in video_coding::PacketBuffer when the buffer is filled with a single frame. (Closed)
Patch Set: new --> new[] Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/video_coding/frame_object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 24 matching lines...) Expand all
35 virtual int64_t ReceivedTime() const = 0; 35 virtual int64_t ReceivedTime() const = 0;
36 36
37 // When this frame should be rendered. 37 // When this frame should be rendered.
38 virtual int64_t RenderTime() const = 0; 38 virtual int64_t RenderTime() const = 0;
39 39
40 // This information is currently needed by the timing calculation class. 40 // This information is currently needed by the timing calculation class.
41 // TODO(philipel): Remove this function when a new timing class has 41 // TODO(philipel): Remove this function when a new timing class has
42 // been implemented. 42 // been implemented.
43 virtual bool delayed_by_retransmission() const { return 0; } 43 virtual bool delayed_by_retransmission() const { return 0; }
44 44
45 size_t size() { return _length; } 45 size_t size() const { return _length; }
46 46
47 // The tuple (|picture_id|, |spatial_layer|) uniquely identifies a frame 47 // The tuple (|picture_id|, |spatial_layer|) uniquely identifies a frame
48 // object. For codec types that don't necessarily have picture ids they 48 // object. For codec types that don't necessarily have picture ids they
49 // have to be constructed from the header data relevant to that codec. 49 // have to be constructed from the header data relevant to that codec.
50 uint16_t picture_id; 50 uint16_t picture_id;
51 uint8_t spatial_layer; 51 uint8_t spatial_layer;
52 uint32_t timestamp; 52 uint32_t timestamp;
53 53
54 // TODO(philipel): Add simple modify/access functions to prevent adding too 54 // TODO(philipel): Add simple modify/access functions to prevent adding too
55 // many |references|. 55 // many |references|.
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 93
94 // Equal to times nacked of the packet with the highet times nacked 94 // Equal to times nacked of the packet with the highet times nacked
95 // belonging to this frame. 95 // belonging to this frame.
96 int times_nacked_; 96 int times_nacked_;
97 }; 97 };
98 98
99 } // namespace video_coding 99 } // namespace video_coding
100 } // namespace webrtc 100 } // namespace webrtc
101 101
102 #endif // WEBRTC_MODULES_VIDEO_CODING_FRAME_OBJECT_H_ 102 #endif // WEBRTC_MODULES_VIDEO_CODING_FRAME_OBJECT_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/video_coding/frame_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698