Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: webrtc/modules/video_coding/sequence_number_util_unittest.cc

Issue 2992643002: Revert of Disable SeqNumUnwrapper death tests to avoid breaking downstream builds. (Closed)
Patch Set: fix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/sequence_number_util_unittest.cc
diff --git a/webrtc/modules/video_coding/sequence_number_util_unittest.cc b/webrtc/modules/video_coding/sequence_number_util_unittest.cc
index 6988b3e8274028a9903b606c23667835219089c3..e0db1a8a5fefb1bbe9b277a758a0ef15e30fed53 100644
--- a/webrtc/modules/video_coding/sequence_number_util_unittest.cc
+++ b/webrtc/modules/video_coding/sequence_number_util_unittest.cc
@@ -209,25 +209,27 @@ TEST_F(TestSeqNumUtil, SeqNumComparatorWithDivisor) {
}
}
-// TODO(philipel): Enable when downstream project can hande these death tests.
-
-TEST(SeqNumUnwrapper, DISABLED_NoBackWardWrap) {
+#if GTEST_HAS_DEATH_TEST
+#if !defined(WEBRTC_ANDROID)
+TEST(SeqNumUnwrapper, NoBackWardWrap) {
SeqNumUnwrapper<uint8_t> unwrapper;
EXPECT_EQ(0U, unwrapper.Unwrap(0));
// The unwrapped sequence is not allowed to wrap, if that happens the
// SeqNumUnwrapper should have been constructed with a higher start value.
- ASSERT_DEATH_IF_SUPPORTED(unwrapper.Unwrap(255), "");
+ EXPECT_DEATH(unwrapper.Unwrap(255), "");
}
-TEST(SeqNumUnwrapper, DISABLED_NoForwardWrap) {
+TEST(SeqNumUnwrapper, NoForwardWrap) {
SeqNumUnwrapper<uint32_t> unwrapper(std::numeric_limits<uint64_t>::max());
EXPECT_EQ(std::numeric_limits<uint64_t>::max(), unwrapper.Unwrap(0));
// The unwrapped sequence is not allowed to wrap, if that happens the
// SeqNumUnwrapper should have been constructed with a lower start value.
- ASSERT_DEATH_IF_SUPPORTED(unwrapper.Unwrap(1), "");
+ EXPECT_DEATH(unwrapper.Unwrap(1), "");
}
+#endif
+#endif
TEST(SeqNumUnwrapper, ForwardWrap) {
SeqNumUnwrapper<uint8_t> unwrapper;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698