ObjC RTCEAGLVideoVideo: Check GL context is non-nil in constructor

webrtc/sdk/objc/Framework/Classes/UI/RTCEAGLVideoView.m

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 103 matching lines @@
   return [self initWithFrame:frame shader:[[RTCDefaultShader alloc] init]];
 }
 
 - (instancetype)initWithCoder:(NSCoder *)aDecoder {
   return [self initWithCoder:aDecoder shader:[[RTCDefaultShader alloc] init]];
 }
 
 - (instancetype)initWithFrame:(CGRect)frame shader:(id<RTCVideoViewShading>)shader {
   if (self = [super initWithFrame:frame]) {
     _shader = shader;
-    [self configure];
+    if (![self configure]) {
+      return nil;
+    }
   }
   return self;
 }
 
 - (instancetype)initWithCoder:(NSCoder *)aDecoder shader:(id<RTCVideoViewShading>)shader {
   if (self = [super initWithCoder:aDecoder]) {
     _shader = shader;
-    [self configure];
+    if (![self configure]) {
+      return nil;
+    }
   }
   return self;
 }
 
-- (void)configure {
+- (BOOL)configure {
   EAGLContext *glContext =
     [[EAGLContext alloc] initWithAPI:kEAGLRenderingAPIOpenGLES3];
   if (!glContext) {
     glContext = [[EAGLContext alloc] initWithAPI:kEAGLRenderingAPIOpenGLES2];
   }
+  if (!glContext) {
+    return NO;

[tkchin_webrtc, 2017/07/27 20:42:12]

nit: add an error log

[magjed_webrtc, 2017/07/31 15:23:23]

Done.

+  }
   _glContext = glContext;
 
   // GLKView manages a framebuffer for us.
   _glkView = [[GLKView alloc] initWithFrame:CGRectZero
                                     context:_glContext];
   _glkView.drawableColorFormat = GLKViewDrawableColorFormatRGBA8888;
   _glkView.drawableDepthFormat = GLKViewDrawableDepthFormatNone;
   _glkView.drawableStencilFormat = GLKViewDrawableStencilFormatNone;
   _glkView.drawableMultisample = GLKViewDrawableMultisampleNone;
   _glkView.delegate = self;
@@ skipping 16 matching lines @@
 
   // Frames are received on a separate thread, so we poll for current frame
   // using a refresh rate proportional to screen refresh frequency. This
   // occurs on the main thread.
   __weak RTCEAGLVideoView *weakSelf = self;
   _timer = [[RTCDisplayLinkTimer alloc] initWithTimerHandler:^{
       RTCEAGLVideoView *strongSelf = weakSelf;
       [strongSelf displayLinkTimerDidFire];
     }];
   [self setupGL];
+  return YES;
 }
 
 - (void)dealloc {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
   UIApplicationState appState =
       [UIApplication sharedApplication].applicationState;
   if (appState == UIApplicationStateActive) {
     [self teardownGL];
   }
   [_timer invalidate];
@@ skipping 121 matching lines @@
 }
 
 - (void)ensureGLContext {
   NSAssert(_glContext, @"context shouldn't be nil");
   if ([EAGLContext currentContext] != _glContext) {
     [EAGLContext setCurrentContext:_glContext];
   }
 }
 
 @end