Implement AndroidVideoBuffer::ToI420.

webrtc/sdk/android/src/jni/native_handle_impl.h

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 86 matching lines @@
   // a global reference. TODO(nisse): Make this a reference to the C++
   // SurfaceTextureHelper instead, but that requires some refactoring
   // of AndroidVideoCapturerJni.
   jobject surface_texture_helper_;
   rtc::Callback0<void> no_longer_used_cb_;
 };
 
 class AndroidVideoBuffer : public AndroidVideoFrameBuffer {
  public:
   AndroidVideoBuffer(JNIEnv* jni,
-                     jmethodID j_retain_id,
                      jmethodID j_release_id,
                      int width,
                      int height,
                      jobject j_video_frame_buffer);
   ~AndroidVideoBuffer() override;
 
   jobject video_frame_buffer() const;
 
   // Returns an instance of VideoRenderer.I420Frame (deprecated)
   jobject ToJavaI420Frame(JNIEnv* jni, int rotation);
 
- private:
   Type type() const override;
   int width() const override;
   int height() const override;
 
+ private:
   rtc::scoped_refptr<webrtc::I420BufferInterface> ToI420() override;
 
   AndroidType android_type() override { return AndroidType::kJavaBuffer; }
 
   const jmethodID j_release_id_;
   const int width_;
   const int height_;
-  // Holds a VideoFrame.Buffer.

[magjed_webrtc, 2017/07/28 09:45:05]

Keep this comment.

[sakal, 2017/07/28 11:08:49]

Done.

-  ScopedGlobalRef<jobject> j_video_frame_buffer_;
+  const ScopedGlobalRef<jobject> j_video_frame_buffer_;
 };
 
 class AndroidVideoBufferFactory {
  public:
   explicit AndroidVideoBufferFactory(JNIEnv* jni);
 
   webrtc::VideoFrame CreateFrame(JNIEnv* jni,
                                  jobject j_video_frame,
                                  uint32_t timestamp_rtp) const;
 
   rtc::scoped_refptr<AndroidVideoBuffer> CreateBuffer(
       jobject j_video_frame_buffer) const;
 
  private:
   ScopedGlobalRef<jclass> j_video_frame_class_;
   jmethodID j_get_buffer_id_;
   jmethodID j_get_rotation_id_;
   jmethodID j_get_timestamp_ns_id_;
 
   ScopedGlobalRef<jclass> j_video_frame_buffer_class_;
   jmethodID j_retain_id_;
   jmethodID j_release_id_;
   jmethodID j_get_width_id_;
   jmethodID j_get_height_id_;
 };
 
 }  // namespace webrtc_jni
 
 #endif  // WEBRTC_SDK_ANDROID_SRC_JNI_NATIVE_HANDLE_IMPL_H_