Make FlexfecReceiveStreamImpl::started_ into std::atomic<bool>

webrtc/call/flexfec_receive_stream_impl.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_CALL_FLEXFEC_RECEIVE_STREAM_IMPL_H_
 #define WEBRTC_CALL_FLEXFEC_RECEIVE_STREAM_IMPL_H_
 
+#include <atomic>
 #include <memory>
 
 #include "webrtc/call/flexfec_receive_stream.h"
 #include "webrtc/call/rtp_packet_sink_interface.h"
 #include "webrtc/rtc_base/criticalsection.h"
 
 namespace webrtc {
 
 class FlexfecReceiver;
 class ProcessThread;
@@ skipping 22 matching lines @@
   void OnRtpPacket(const RtpPacketReceived& packet) override;
 
   // Implements FlexfecReceiveStream.
   void Start() override;
   void Stop() override;
   Stats GetStats() const override;
 
  private:
   // Config.
   const Config config_;
-  bool started_ GUARDED_BY(crit_);
-  rtc::CriticalSection crit_;
+  std::atomic<bool> started_;

[brandtr, 2017/08/01 07:08:02]

The start/stop functionality doesn't really serve a purpose for the
FlexfecReceiveStream. I have discussed this with nisse, and he is planning on
removing it completely.

[eladalon, 2017/08/01 08:27:46]

Okay, thanks.
In the meantime, do you think should I scrap the CL, or that I should land it?

[brandtr, 2017/08/01 08:39:03]

Might as well land it, since it's a nice improvement and you have done the work
already :)

 
   // Erasure code interfacing.
   const std::unique_ptr<FlexfecReceiver> receiver_;
 
   // RTCP reporting.
   const std::unique_ptr<ReceiveStatistics> rtp_receive_statistics_;
   const std::unique_ptr<RtpRtcp> rtp_rtcp_;
   ProcessThread* process_thread_;
 
   std::unique_ptr<RtpStreamReceiverInterface> rtp_stream_receiver_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_CALL_FLEXFEC_RECEIVE_STREAM_IMPL_H_