Make FlexfecReceiveStreamImpl::started_ into std::atomic<bool>

webrtc/call/flexfec_receive_stream_impl.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 150 matching lines @@
     receiver_controller->AddSink(ssrc, this);
 }
 
 FlexfecReceiveStreamImpl::~FlexfecReceiveStreamImpl() {
   LOG(LS_INFO) << "~FlexfecReceiveStreamImpl: " << config_.ToString();
   Stop();
   process_thread_->DeRegisterModule(rtp_rtcp_.get());
 }
 
 void FlexfecReceiveStreamImpl::OnRtpPacket(const RtpPacketReceived& packet) {
-  {
-    rtc::CritScope cs(&crit_);
-    if (!started_)
-      return;
-  }
+  if (!started_)

[danilchap, 2017/07/24 13:40:23]

prefer .load() over operator bool to be explicit it is an atomic

[eladalon, 2017/07/24 16:09:02]

Done.

+    return;
 
   if (!receiver_)
     return;
 
   receiver_->OnRtpPacket(packet);
 
   // Do not report media packets in the RTCP RRs generated by |rtp_rtcp_|.
   if (packet.Ssrc() == config_.remote_ssrc) {
     RTPHeader header;
     packet.GetHeader(&header);
     // FlexFEC packets are never retransmitted.
     const bool kNotRetransmitted = false;
     rtp_receive_statistics_->IncomingPacket(header, packet.size(),
                                             kNotRetransmitted);
   }
 }
 
 void FlexfecReceiveStreamImpl::Start() {
-  rtc::CritScope cs(&crit_);
   started_ = true;

[danilchap, 2017/07/24 13:40:23]

same here: prefer store

[eladalon, 2017/07/24 16:09:02]

Done.

 }
 
 void FlexfecReceiveStreamImpl::Stop() {
-  rtc::CritScope cs(&crit_);
   started_ = false;
 }
 
 // TODO(brandtr): Implement this member function when we have designed the
 // stats for FlexFEC.
 FlexfecReceiveStreamImpl::Stats FlexfecReceiveStreamImpl::GetStats() const {
   return FlexfecReceiveStream::Stats();
 }
 
 }  // namespace webrtc