Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1834)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2991443002: The Appcache subresource URL factory needs to inform the URLLoaderClient if there is a failure. (Closed)
Patch Set: Disable the test for Android Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/appcache/appcache_url_loader_job.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 1153000a67890a8d1cdf2883fb0c8437f9be3f73..ad23246aa7897829c61443d9c2325d12fdcf4722 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -5163,11 +5163,9 @@ void RenderFrameImpl::OnCommitNavigation(
},
weak_factory_.GetWeakPtr());
- if (commit_data.url_loader_factory.is_valid()) {
- // Chrome doesn't use interface versioning.
- url_loader_factory_.Bind(mojom::URLLoaderFactoryPtrInfo(
- mojo::ScopedMessagePipeHandle(commit_data.url_loader_factory), 0u));
- }
+ // Chrome doesn't use interface versioning.
+ url_loader_factory_.Bind(mojom::URLLoaderFactoryPtrInfo(
+ mojo::ScopedMessagePipeHandle(commit_data.url_loader_factory), 0u));
// If the request was initiated in the context of a user gesture then make
// sure that the navigation also executes in the context of a user gesture.
« no previous file with comments | « content/browser/appcache/appcache_url_loader_job.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698