webrtc/sdk/android/instrumentationtests/src/org/webrtc/NetworkMonitorTest.java - Issue 2990693002: Fix issues with NetworkMonitor singleton when used by multiple clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/android/instrumentationtests/src/org/webrtc/NetworkMonitorTest.java

Issue 2990693002: Fix issues with NetworkMonitor singleton when used by multiple clients. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/sdk/android/api/org/webrtc/NetworkMonitor.java ('K') | « webrtc/sdk/android/api/org/webrtc/NetworkMonitor.java ('k') | webrtc/sdk/android/src/jni/androidnetworkmonitor_jni.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/android/instrumentationtests/src/org/webrtc/NetworkMonitorTest.java

diff --git a/webrtc/sdk/android/instrumentationtests/src/org/webrtc/NetworkMonitorTest.java b/webrtc/sdk/android/instrumentationtests/src/org/webrtc/NetworkMonitorTest.java

index f8cdd086853df0d82146fe213a9d2c00f6ee64c0..923bd3ccf0aba038bf0979916365995240ad1070 100644

--- a/webrtc/sdk/android/instrumentationtests/src/org/webrtc/NetworkMonitorTest.java

+++ b/webrtc/sdk/android/instrumentationtests/src/org/webrtc/NetworkMonitorTest.java

@@ -41,6 +41,10 @@ import org.junit.runner.RunWith;

/**

* Tests for org.webrtc.NetworkMonitor.

+ *

+ * TODO(deadbeef): These tests don't cover the interaction between

+ * NetworkManager.java and androidnetworkmonitor_jni.cc, which is how this

+ * class is used in practice in WebRTC.

@SuppressLint("NewApi")

@RunWith(BaseJUnit4ClassRunner.class)

@@ -162,7 +166,7 @@ public class NetworkMonitorTest {

private void createTestMonitor() {

Context context = InstrumentationRegistry.getTargetContext();

NetworkMonitor.resetInstanceForTests();

- NetworkMonitor.setAutoDetectConnectivityState(true);

+ NetworkMonitor.createAutoDetectorForTest();

receiver = NetworkMonitor.getAutoDetectorForTest();

assertNotNull(receiver);