Add Jpeg frame writer for test support.

webrtc/test/testsupport/test_output.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/test/testsupport/test_output.h"
 
 #include <string.h>
 
-#include "gflags/gflags.h"
+#include "webrtc/rtc_base/flags.h"
 #include "webrtc/rtc_base/file.h"
 #include "webrtc/rtc_base/logging.h"
 #include "webrtc/rtc_base/pathutils.h"
 #include "webrtc/test/testsupport/fileutils.h"
 
+// Have to be strdup because |DEFINE_string| macro defines |char*|.
 DEFINE_string(test_output_dir,
-              webrtc::test::OutputPath(),
+              strdup(webrtc::test::OutputPath().c_str()),

[pbos-webrtc, 2017/07/26 18:48:03]

I think this should be a const std::string kDefaultOutputPath =
webrtc::test::OutputPath(); then, this strdup leaks.

Use kDefaultOutputPath.c_str() as a default value then.

[ilnik, 2017/08/17 11:35:07]

Done.

               "The output folder where test output should be saved.");
 
 namespace webrtc {
 namespace test {
 
 bool GetTestOutputDir(std::string* out_dir) {
-  if (FLAGS_test_output_dir.empty()) {
+  if (FLAG_test_output_dir == nullptr || strlen(FLAG_test_output_dir) == 0) {

[pbos-webrtc, 2017/07/26 18:48:03]

Can this be if (std::string(FLAG_test_output_dir) != "", or
strcmp(FLAG_test_output_dir, "") == 0)?

This should never be nullptr, right?

[ilnik, 2017/08/17 11:35:07]

Yes, it can't be nullptr ever. Still, I think strlen fits here better.

     LOG(LS_WARNING) << "No test_out_dir defined.";
     return false;
   }
-  *out_dir = FLAGS_test_output_dir;
+  *out_dir = FLAG_test_output_dir;
   return true;
 }
 
 bool WriteToTestOutput(const char* filename,
                        const uint8_t* buffer,
                        size_t length) {
-  if (FLAGS_test_output_dir.empty()) {
+  if (FLAG_test_output_dir == nullptr || strlen(FLAG_test_output_dir) == 0) {

[pbos-webrtc, 2017/07/26 18:48:03]

ditto

[ilnik, 2017/08/17 11:35:07]

Done.

     LOG(LS_WARNING) << "No test_out_dir defined.";
     return false;
   }
 
   if (filename == nullptr || strlen(filename) == 0) {
     LOG(LS_WARNING) << "filename must be provided.";
     return false;
   }
 
   rtc::File output =
-      rtc::File::Create(rtc::Pathname(FLAGS_test_output_dir, filename));
+      rtc::File::Create(rtc::Pathname(FLAG_test_output_dir, filename));
 
   return output.IsOpen() && output.Write(buffer, length) == length;
 }
 
 bool WriteToTestOutput(const char* filename, const std::string& content) {
   return WriteToTestOutput(filename,
                            reinterpret_cast<const uint8_t*>(content.c_str()),
                            content.length());
 }
 
 }  // namespace test
 }  // namespace webrtc