webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc - Issue 2990163002: Almost full implementation of BBR's core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc

Issue 2990163002: Almost full implementation of BBR's core. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter.h ('K') | « webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc

index 2b7d5b59b89fe8a5b75e75024ae7124e6c07d59d..3ee917536121cc97df6927f1374fcc7b65998e4a 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc

+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc

@@ -23,18 +23,21 @@ TEST(MinRttFilterTest, InitializationCheck) {

TEST(MinRttFilterTest, AddRttSample) {

MinRttFilter min_rtt_filter;

- min_rtt_filter.add_rtt_sample(120, 5);

+ min_rtt_filter.add_rtt_sample(120, 5, false);

EXPECT_EQ(min_rtt_filter.min_rtt_ms(), 120);

EXPECT_EQ(min_rtt_filter.discovery_time(), 5);

- min_rtt_filter.add_rtt_sample(121, 6);

+ min_rtt_filter.add_rtt_sample(121, 6, false);

EXPECT_EQ(min_rtt_filter.discovery_time(), 5);

- min_rtt_filter.add_rtt_sample(119, 7);

+ min_rtt_filter.add_rtt_sample(119, 7, false);

EXPECT_EQ(min_rtt_filter.discovery_time(), 7);

+ min_rtt_filter.add_rtt_sample(140, 17, true);

+ EXPECT_EQ(min_rtt_filter.discovery_time(), 17);

+ EXPECT_EQ(min_rtt_filter.min_rtt_ms(), 140);

}

TEST(MinRttFilterTest, MinRttExpired) {

MinRttFilter min_rtt_filter;

- min_rtt_filter.add_rtt_sample(120, 5);

+ min_rtt_filter.add_rtt_sample(120, 5, false);

EXPECT_EQ(min_rtt_filter.min_rtt_expired(10, 5), true);

EXPECT_EQ(min_rtt_filter.min_rtt_expired(9, 5), false);

}