webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoEncoderSettings.mm - Issue 2989803002: ObjC style fix for injectable video codecs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoEncoderSettings.mm

Issue 2989803002: ObjC style fix for injectable video codecs (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm ('k') | webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoEncoderSettings.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoEncoderSettings.mm b/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoEncoderSettings.mm

index 3ddf63bb7b2c14fd57356c685f08868879f2813c..018e76a74ed1b538463d4d5ea7fdd9b8cac42af4 100644

--- a/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoEncoderSettings.mm

+++ b/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoEncoderSettings.mm

@@ -26,7 +26,7 @@

@synthesize maxFramerate = _maxFramerate;

@synthesize qpMax = _qpMax;

-- (instancetype)initWithVideoCodec:(const webrtc::VideoCodec *__nullable)videoCodec {

+- (instancetype)initWithNativeVideoCodec:(const webrtc::VideoCodec *)videoCodec {

if (self = [super init]) {

if (videoCodec) {

rtc::Optional<const char *> codecName = CodecTypeToPayloadName(videoCodec->codecType);

@@ -48,7 +48,7 @@

return self;

}

-- (std::unique_ptr<webrtc::VideoCodec>)toCpp {

+- (std::unique_ptr<webrtc::VideoCodec>)createNativeVideoEncoderSettings {

auto codecSettings = std::unique_ptr<webrtc::VideoCodec>(new webrtc::VideoCodec);

rtc::Optional<webrtc::VideoCodecType> codecType =