Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm

Issue 2989803002: ObjC style fix for injectable video codecs (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 14 matching lines...) Expand all
25 parameters:(NSDictionary<NSString *, NSString *> *)paramete rs { 25 parameters:(NSDictionary<NSString *, NSString *> *)paramete rs {
26 if (self = [super init]) { 26 if (self = [super init]) {
27 _payload = payload; 27 _payload = payload;
28 _name = name; 28 _name = name;
29 _parameters = parameters; 29 _parameters = parameters;
30 } 30 }
31 31
32 return self; 32 return self;
33 } 33 }
34 34
35 - (instancetype)initWithVideoCodec:(cricket::VideoCodec)videoCodec { 35 - (instancetype)initWithNativeVideoCodec:(cricket::VideoCodec)videoCodec {
36 NSMutableDictionary *params = [NSMutableDictionary dictionary]; 36 NSMutableDictionary *params = [NSMutableDictionary dictionary];
37 for (auto it = videoCodec.params.begin(); it != videoCodec.params.end(); ++it) { 37 for (auto it = videoCodec.params.begin(); it != videoCodec.params.end(); ++it) {
38 [params setObject:[NSString stringForStdString:it->second] 38 [params setObject:[NSString stringForStdString:it->second]
39 forKey:[NSString stringForStdString:it->first]]; 39 forKey:[NSString stringForStdString:it->first]];
40 } 40 }
41 return [self initWithPayload:videoCodec.id 41 return [self initWithPayload:videoCodec.id
42 name:[NSString stringForStdString:videoCodec.name] 42 name:[NSString stringForStdString:videoCodec.name]
43 parameters:params]; 43 parameters:params];
44 } 44 }
45 45
46 - (cricket::VideoCodec)toCpp { 46 - (cricket::VideoCodec)nativeVideoCodec {
47 cricket::VideoCodec codec([NSString stdStringForString:_name]); 47 cricket::VideoCodec codec([NSString stdStringForString:_name]);
48 for (NSString *paramKey in _parameters.allKeys) { 48 for (NSString *paramKey in _parameters.allKeys) {
49 codec.SetParam([NSString stdStringForString:paramKey], 49 codec.SetParam([NSString stdStringForString:paramKey],
50 [NSString stdStringForString:_parameters[paramKey]]); 50 [NSString stdStringForString:_parameters[paramKey]]);
51 } 51 }
52 52
53 return codec; 53 return codec;
54 } 54 }
55 55
56 @end 56 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698