Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: runtime/observatory/lib/src/service/object.dart

Issue 2989493002: Simplify and fix implicit closure check, speed up Closure_equals (Closed)
Patch Set: Avoid overloaded NewClosureFunction Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of service; 5 part of service;
6 6
7 // Some value smaller than the object ring, so requesting a large array 7 // Some value smaller than the object ring, so requesting a large array
8 // doesn't result in an expired ref because the elements lapped it in the 8 // doesn't result in an expired ref because the elements lapped it in the
9 // object ring. 9 // object ring.
10 const int kDefaultFieldLimit = 100; 10 const int kDefaultFieldLimit = 100;
(...skipping 2989 matching lines...) Expand 10 before | Expand all | Expand 10 after
3000 3000
3001 ContextElement(Map map) : value = new Guarded<Instance>(map['value']); 3001 ContextElement(Map map) : value = new Guarded<Instance>(map['value']);
3002 } 3002 }
3003 3003
3004 M.FunctionKind stringToFunctionKind(String value) { 3004 M.FunctionKind stringToFunctionKind(String value) {
3005 switch (value) { 3005 switch (value) {
3006 case 'RegularFunction': 3006 case 'RegularFunction':
3007 return M.FunctionKind.regular; 3007 return M.FunctionKind.regular;
3008 case 'ClosureFunction': 3008 case 'ClosureFunction':
3009 return M.FunctionKind.closure; 3009 return M.FunctionKind.closure;
3010 case 'ImplicitClosureFunction':
3011 return M.FunctionKind.implicitClosure;
3010 case 'GetterFunction': 3012 case 'GetterFunction':
3011 return M.FunctionKind.getter; 3013 return M.FunctionKind.getter;
3012 case 'SetterFunction': 3014 case 'SetterFunction':
3013 return M.FunctionKind.setter; 3015 return M.FunctionKind.setter;
3014 case 'Constructor': 3016 case 'Constructor':
3015 return M.FunctionKind.constructor; 3017 return M.FunctionKind.constructor;
3016 case 'ImplicitGetter': 3018 case 'ImplicitGetter':
3017 return M.FunctionKind.implicitGetter; 3019 return M.FunctionKind.implicitGetter;
3018 case 'ImplicitSetter': 3020 case 'ImplicitSetter':
3019 return M.FunctionKind.implicitSetter; 3021 return M.FunctionKind.implicitSetter;
(...skipping 1677 matching lines...) Expand 10 before | Expand all | Expand 10 after
4697 final String alias; 4699 final String alias;
4698 final String method; 4700 final String method;
4699 final String service; 4701 final String service;
4700 4702
4701 Service(this.alias, this.method, this.service) { 4703 Service(this.alias, this.method, this.service) {
4702 assert(this.alias != null); 4704 assert(this.alias != null);
4703 assert(this.method != null); 4705 assert(this.method != null);
4704 assert(this.service != null); 4706 assert(this.service != null);
4705 } 4707 }
4706 } 4708 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698