runtime/observatory/lib/src/models/objects/function.dart - Issue 2989493002: Simplify and fix implicit closure check, speed up Closure_equals

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/observatory/lib/src/models/objects/function.dart

Issue 2989493002: Simplify and fix implicit closure check, speed up Closure_equals (Closed)

Patch Set: Avoid overloaded NewClosureFunction Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 part of models;	5 part of models;

6	6

7 enum FunctionKind {	7 enum FunctionKind {

8 regular,	8 regular,

9 closure,	9 closure,

	10 implicitClosure,

10 getter,	11 getter,

11 setter,	12 setter,

12 constructor,	13 constructor,

13 implicitGetter,	14 implicitGetter,

14 implicitSetter,	15 implicitSetter,

15 implicitStaticFinalGetter,	16 implicitStaticFinalGetter,

16 irregexpFunction,	17 irregexpFunction,

17 staticInitializer,	18 staticInitializer,

18 methodExtractor,	19 methodExtractor,

19 noSuchMethodDispatcher,	20 noSuchMethodDispatcher,

(...skipping 68 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
88 FieldRef get field;	89 FieldRef get field;

89 int get usageCounter;	90 int get usageCounter;

90 InstanceRef get icDataArray;	91 InstanceRef get icDataArray;

91 int get deoptimizations;	92 int get deoptimizations;

92 bool get isOptimizable;	93 bool get isOptimizable;

93 bool get isInlinable;	94 bool get isInlinable;

94 bool get hasIntrinsic;	95 bool get hasIntrinsic;

95 bool get isRecognized;	96 bool get isRecognized;

96 bool get isNative;	97 bool get isNative;

97 }	98 }

OLD	NEW

« runtime/lib/function.cc ('K') | « runtime/observatory/lib/src/elements/function_view.dart ('k') | runtime/observatory/lib/src/service/object.dart » ('j') | no next file with comments »