Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2989383002: Revert of SSRC and RSID may only refer to one sink each in RtpDemuxer (Closed)

Created:
3 years, 4 months ago by charujain
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of SSRC and RSID may only refer to one sink each in RtpDemuxer (patchset #15 id:280001 of https://codereview.webrtc.org/2968693002/ ) Reason for revert: Break internal projects Original issue's description: > SSRC and RSID may only refer to one sink each in RtpDemuxer > > RTP demuxing should only match RTP packets with one sink. > > BUG=webrtc:7135 > > Review-Url: https://codereview.webrtc.org/2968693002 > Cr-Commit-Position: refs/heads/master@{#19233} > Committed: https://chromium.googlesource.com/external/webrtc/+/7b7e06fd23ac67d81f378b773bb631abb1d82116 TBR=nisse@webrtc.org,danilchap@webrtc.org,perkj@webrtc.org,stefan@webrtc.org,holmer@google.com,deadbeef@webrtc.org,pthatcher@webrtc.org,steveanton@webrtc.org,eladalon@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -289 lines) Patch
M webrtc/call/rtp_demuxer.h View 3 chunks +13 lines, -11 lines 0 comments Download
M webrtc/call/rtp_demuxer.cc View 2 chunks +32 lines, -37 lines 0 comments Download
M webrtc/call/rtp_demuxer_unittest.cc View 9 chunks +60 lines, -206 lines 0 comments Download
M webrtc/call/rtp_rtcp_demuxer_helper.h View 4 chunks +0 lines, -25 lines 0 comments Download
M webrtc/call/rtp_stream_receiver_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/rtp_stream_receiver_controller.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M webrtc/call/rtp_stream_receiver_controller_interface.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
charujain
Created Revert of SSRC and RSID may only refer to one sink each in RtpDemuxer
3 years, 4 months ago (2017-08-03 17:51:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2989383002/1
3 years, 4 months ago (2017-08-03 17:51:26 UTC) #3
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/heads/master'. nothing ...
3 years, 4 months ago (2017-08-03 17:51:33 UTC) #5
eladalon
3 years, 4 months ago (2017-08-04 09:15:10 UTC) #6
This seems to have been reverted with a different CL, so I guess this CL can be
removed?

Powered by Google App Engine
This is Rietveld 408576698