Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2988563002: Fixed errors related to bad-continuation (Closed)

Created:
3 years, 5 months ago by Lo-Lo
Modified:
3 years, 5 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Fixed errors related to bad-continuation Fixed pylint errors in: telemetry/telemetry/internal/browser/tab_unittest.py telemetry/telemetry/internal/platform/android_device_unittest.py telemetry/telemetry/internal/platform/android_platform_backend_unittest.py telemetry/telemetry/internal/platform/gpu_device.py Part 12 BUG=catapult:#3604 Review-Url: https://codereview.chromium.org/2988563002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b60f7c4180378d32e541ddc8358ec8c88b8288ea

Patch Set 1 #

Patch Set 2 : Fixed additional errors #

Patch Set 3 : Removed pylintrc changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M telemetry/telemetry/internal/browser/tab_unittest.py View 1 2 chunks +5 lines, -4 lines 0 comments Download
M telemetry/telemetry/internal/platform/android_device_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M telemetry/telemetry/internal/platform/android_platform_backend_unittest.py View 1 1 chunk +11 lines, -11 lines 0 comments Download
M telemetry/telemetry/internal/platform/gpu_device.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Lo-Lo
Hey, Here are additional fixes related to the bad-continuation param. - Lori
3 years, 5 months ago (2017-07-22 16:59:23 UTC) #14
ashleymarie1
On 2017/07/22 16:59:23, Lo-Lo wrote: > Hey, > > Here are additional fixes related to ...
3 years, 5 months ago (2017-07-22 19:36:21 UTC) #15
nednguyen
lgtm
3 years, 5 months ago (2017-07-24 10:40:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2988563002/40001
3 years, 5 months ago (2017-07-24 13:24:30 UTC) #18
commit-bot: I haz the power
3 years, 5 months ago (2017-07-24 14:01:36 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698