webrtc/modules/video_coding/frame_object.cc - Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/frame_object.cc

Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls (Closed)

Patch Set: fix mistakes Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/frame_object.cc

diff --git a/webrtc/modules/video_coding/frame_object.cc b/webrtc/modules/video_coding/frame_object.cc

index 25d0e29d218c1538c89637e783d402993bf18020..1d858fcc0ea0febbd8917a262ed25187c05d19aa 100644

--- a/webrtc/modules/video_coding/frame_object.cc

+++ b/webrtc/modules/video_coding/frame_object.cc

@@ -102,7 +102,8 @@ RtpFrameObject::RtpFrameObject(PacketBuffer* packet_buffer,

timestamp = first_packet->timestamp;

VCMPacket* last_packet = packet_buffer_->GetPacket(last_seq_num);

- RTC_CHECK(last_packet && last_packet->markerBit);

+ RTC_CHECK(last_packet);

+ RTC_CHECK(last_packet->markerBit);

// http://www.etsi.org/deliver/etsi_ts/126100_126199/126114/12.07.00_60/

// ts_126114v120700p.pdf Section 7.4.5.

// The MTSI client shall add the payload bytes as defined in this clause