Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log_parser.cc

Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls (Closed)
Patch Set: fix mistakes Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log_parser.cc
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log_parser.cc b/webrtc/logging/rtc_event_log/rtc_event_log_parser.cc
index 8a8d8e3d472e48b0b70c1262ad86f496bb45b273..a7237ee8511507228ee026a08e7440f522138976 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log_parser.cc
+++ b/webrtc/logging/rtc_event_log/rtc_event_log_parser.cc
@@ -104,7 +104,8 @@ std::pair<uint64_t, bool> ParseVarInt(std::istream& stream) {
if (stream.eof()) {
return std::make_pair(varint, false);
}
- RTC_DCHECK(0 <= byte && byte <= 255);
+ RTC_DCHECK_GE(byte, 0);
+ RTC_DCHECK_LE(byte, 255);
varint |= static_cast<uint64_t>(byte & 0x7F) << (7 * bytes_read);
if ((byte & 0x80) == 0) {
return std::make_pair(varint, true);
« no previous file with comments | « webrtc/logging/rtc_event_log/rtc_event_log2stats.cc ('k') | webrtc/modules/audio_coding/codecs/cng/webrtc_cng.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698