webrtc/call/audio_send_stream.h - Issue 2987763003: Make ~webrtc::AudioSendStream public, and s/config()/GetConfig(), as well as make public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/call/audio_send_stream.h

Issue 2987763003: Make ~webrtc::AudioSendStream public, and s/config()/GetConfig(), as well as make public. (Closed)

Patch Set: Discussed offline with Fredrick; implement. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/call/audio_send_stream.h

diff --git a/webrtc/call/audio_send_stream.h b/webrtc/call/audio_send_stream.h

index 26729e426cb835613ad61d610a19a9b0bb26f5d0..7e2885682f4cd5c947c6cebc3aad0d49c18dbcc2 100644

--- a/webrtc/call/audio_send_stream.h

+++ b/webrtc/call/audio_send_stream.h

@@ -31,6 +31,8 @@ namespace webrtc {

class AudioSendStream {

public:

+ virtual ~AudioSendStream() = default;

danilchap 2017/07/25 14:42:20 nit: put destructor after child types.

eladalon 2017/07/26 08:43:05 Done.

struct Stats {

Stats();

~Stats();

@@ -147,8 +149,7 @@ class AudioSendStream {

virtual Stats GetStats() const = 0;

- protected:

- virtual ~AudioSendStream() {}

+ virtual const webrtc::AudioSendStream::Config& GetConfig() const = 0;

the sun 2017/07/25 21:26:49 nit: try order methods the same in interface.h, im

eladalon 2017/07/26 08:43:05 Done.

};

} // namespace webrtc

« no previous file with comments | « webrtc/audio/audio_send_stream.cc ('k') | webrtc/call/call.cc » ('j') | no next file with comments »