Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: webrtc/call/audio_send_stream.h

Issue 2987763003: Make ~webrtc::AudioSendStream public, and s/config()/GetConfig(), as well as make public. (Closed)
Patch Set: CR response Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/audio/audio_send_stream.cc ('k') | webrtc/call/call.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 bool transport_cc_enabled = false; 122 bool transport_cc_enabled = false;
123 rtc::Optional<int> cng_payload_type; 123 rtc::Optional<int> cng_payload_type;
124 // If unset, use the encoder's default target bitrate. 124 // If unset, use the encoder's default target bitrate.
125 rtc::Optional<int> target_bitrate_bps; 125 rtc::Optional<int> target_bitrate_bps;
126 }; 126 };
127 127
128 rtc::Optional<SendCodecSpec> send_codec_spec; 128 rtc::Optional<SendCodecSpec> send_codec_spec;
129 rtc::scoped_refptr<AudioEncoderFactory> encoder_factory; 129 rtc::scoped_refptr<AudioEncoderFactory> encoder_factory;
130 }; 130 };
131 131
132 virtual ~AudioSendStream() = default;
133
134 virtual const webrtc::AudioSendStream::Config& GetConfig() const = 0;
135
132 // Reconfigure the stream according to the Configuration. 136 // Reconfigure the stream according to the Configuration.
133 virtual void Reconfigure(const Config& config) = 0; 137 virtual void Reconfigure(const Config& config) = 0;
134 138
135 // Starts stream activity. 139 // Starts stream activity.
136 // When a stream is active, it can receive, process and deliver packets. 140 // When a stream is active, it can receive, process and deliver packets.
137 virtual void Start() = 0; 141 virtual void Start() = 0;
138 // Stops stream activity. 142 // Stops stream activity.
139 // When a stream is stopped, it can't receive, process or deliver packets. 143 // When a stream is stopped, it can't receive, process or deliver packets.
140 virtual void Stop() = 0; 144 virtual void Stop() = 0;
141 145
142 // TODO(solenberg): Make payload_type a config property instead. 146 // TODO(solenberg): Make payload_type a config property instead.
143 virtual bool SendTelephoneEvent(int payload_type, int payload_frequency, 147 virtual bool SendTelephoneEvent(int payload_type, int payload_frequency,
144 int event, int duration_ms) = 0; 148 int event, int duration_ms) = 0;
145 149
146 virtual void SetMuted(bool muted) = 0; 150 virtual void SetMuted(bool muted) = 0;
147 151
148 virtual Stats GetStats() const = 0; 152 virtual Stats GetStats() const = 0;
149
150 protected:
151 virtual ~AudioSendStream() {}
152 }; 153 };
153 } // namespace webrtc 154 } // namespace webrtc
154 155
155 #endif // WEBRTC_CALL_AUDIO_SEND_STREAM_H_ 156 #endif // WEBRTC_CALL_AUDIO_SEND_STREAM_H_
OLDNEW
« no previous file with comments | « webrtc/audio/audio_send_stream.cc ('k') | webrtc/call/call.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698