Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: webrtc/call/audio_send_stream.h

Issue 2987763003: Make ~webrtc::AudioSendStream public, and s/config()/GetConfig(), as well as make public. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_CALL_AUDIO_SEND_STREAM_H_ 11 #ifndef WEBRTC_CALL_AUDIO_SEND_STREAM_H_
12 #define WEBRTC_CALL_AUDIO_SEND_STREAM_H_ 12 #define WEBRTC_CALL_AUDIO_SEND_STREAM_H_
13 13
14 #include <memory> 14 #include <memory>
15 #include <string> 15 #include <string>
16 #include <vector> 16 #include <vector>
17 17
18 #include "webrtc/api/audio_codecs/audio_encoder_factory.h" 18 #include "webrtc/api/audio_codecs/audio_encoder_factory.h"
19 #include "webrtc/api/audio_codecs/audio_format.h" 19 #include "webrtc/api/audio_codecs/audio_format.h"
20 #include "webrtc/api/call/transport.h" 20 #include "webrtc/api/call/transport.h"
21 #include "webrtc/audio/time_interval.h"
21 #include "webrtc/config.h" 22 #include "webrtc/config.h"
23 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
22 #include "webrtc/rtc_base/optional.h" 24 #include "webrtc/rtc_base/optional.h"
23 #include "webrtc/typedefs.h" 25 #include "webrtc/typedefs.h"
24 26
25 namespace webrtc { 27 namespace webrtc {
26 28
27 // WORK IN PROGRESS 29 // WORK IN PROGRESS
28 // This class is under development and is not yet intended for for use outside 30 // This class is under development and is not yet intended for for use outside
29 // of WebRtc/Libjingle. Please use the VoiceEngine API instead. 31 // of WebRtc/Libjingle. Please use the VoiceEngine API instead.
30 // See: https://bugs.chromium.org/p/webrtc/issues/detail?id=4690 32 // See: https://bugs.chromium.org/p/webrtc/issues/detail?id=4690
31 33
32 class AudioSendStream { 34 class AudioSendStream {
33 public: 35 public:
36 virtual ~AudioSendStream() = default;
37
34 struct Stats { 38 struct Stats {
35 Stats(); 39 Stats();
36 ~Stats(); 40 ~Stats();
37 41
38 // TODO(solenberg): Harmonize naming and defaults with receive stream stats. 42 // TODO(solenberg): Harmonize naming and defaults with receive stream stats.
39 uint32_t local_ssrc = 0; 43 uint32_t local_ssrc = 0;
40 int64_t bytes_sent = 0; 44 int64_t bytes_sent = 0;
41 int32_t packets_sent = 0; 45 int32_t packets_sent = 0;
42 int32_t packets_lost = -1; 46 int32_t packets_lost = -1;
43 float fraction_lost = -1.0f; 47 float fraction_lost = -1.0f;
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 virtual void Stop() = 0; 144 virtual void Stop() = 0;
141 145
142 // TODO(solenberg): Make payload_type a config property instead. 146 // TODO(solenberg): Make payload_type a config property instead.
143 virtual bool SendTelephoneEvent(int payload_type, int payload_frequency, 147 virtual bool SendTelephoneEvent(int payload_type, int payload_frequency,
144 int event, int duration_ms) = 0; 148 int event, int duration_ms) = 0;
145 149
146 virtual void SetMuted(bool muted) = 0; 150 virtual void SetMuted(bool muted) = 0;
147 151
148 virtual Stats GetStats() const = 0; 152 virtual Stats GetStats() const = 0;
149 153
150 protected: 154 virtual const webrtc::AudioSendStream::Config& GetConfig() const = 0;
151 virtual ~AudioSendStream() {} 155
156 virtual RtpState GetRtpState() const = 0;
157
158 virtual const TimeInterval& GetActiveLifetime() const = 0;
152 }; 159 };
153 } // namespace webrtc 160 } // namespace webrtc
154 161
155 #endif // WEBRTC_CALL_AUDIO_SEND_STREAM_H_ 162 #endif // WEBRTC_CALL_AUDIO_SEND_STREAM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698