Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2987633002: Added functionality to dump relevant status file entries to a single file to make it easier to see … (Closed)

Created:
3 years, 5 months ago by bkonyi
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added functionality to dump relevant status file entries to a single file to make it easier to see which tests have which status file entries. Future work: remove entries from original status files. BUG= R=jcollins@google.com, rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/caf87da9ed218f45cd68ca2f52253c8b913eb53a

Patch Set 1 #

Total comments: 19

Patch Set 2 : Updated to use pkg:status_file, and updated to improve performance #

Total comments: 8

Patch Set 3 : Addressed additional comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -17 lines) Patch
M pkg/status_file/lib/status_file.dart View 1 2 6 chunks +16 lines, -12 lines 0 comments Download
M tools/migration/.packages View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/migration/bin/migrate_batch.dart View 1 2 5 chunks +75 lines, -3 lines 0 comments Download
M tools/migration/pubspec.yaml View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
bkonyi
I've been finding digging around status files looking for particular tests really annoying, so I've ...
3 years, 5 months ago (2017-07-23 03:12:14 UTC) #2
jcollins
LGTM in general once these are fixed, this could definitely save us some time. If ...
3 years, 5 months ago (2017-07-24 18:24:52 UTC) #3
bkonyi
I like the idea of having a separate tool to cleanup these status files, so ...
3 years, 5 months ago (2017-07-24 19:16:05 UTC) #4
Bob Nystrom
I agree totally that the status file monkeying is tedious and this is a good ...
3 years, 5 months ago (2017-07-24 21:47:47 UTC) #5
bkonyi
I've updated the code to use pkg:status_file and now check for the relevant entries in ...
3 years, 5 months ago (2017-07-25 22:13:40 UTC) #6
Bob Nystrom
Much better! https://codereview.chromium.org/2987633002/diff/20001/tools/migration/bin/migrate_batch.dart File tools/migration/bin/migrate_batch.dart (right): https://codereview.chromium.org/2987633002/diff/20001/tools/migration/bin/migrate_batch.dart#newcode120 tools/migration/bin/migrate_batch.dart:120: var statusFileEntries = new StringBuffer(); Instead of ...
3 years, 5 months ago (2017-07-25 23:48:21 UTC) #7
bkonyi
https://codereview.chromium.org/2987633002/diff/20001/tools/migration/bin/migrate_batch.dart File tools/migration/bin/migrate_batch.dart (right): https://codereview.chromium.org/2987633002/diff/20001/tools/migration/bin/migrate_batch.dart#newcode120 tools/migration/bin/migrate_batch.dart:120: var statusFileEntries = new StringBuffer(); On 2017/07/25 23:48:21, Bob ...
3 years, 5 months ago (2017-07-26 00:27:12 UTC) #8
Bob Nystrom
LGTM!
3 years, 5 months ago (2017-07-26 00:40:18 UTC) #9
bkonyi
3 years, 5 months ago (2017-07-26 00:48:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
caf87da9ed218f45cd68ca2f52253c8b913eb53a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698