webrtc/sdk/objc/Framework/UnitTests/objc_video_encoder_factory_tests.mm - Issue 2987413002: ObjC: Implement HW codecs in ObjC instead of C++

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/UnitTests/objc_video_encoder_factory_tests.mm

Issue 2987413002: ObjC: Implement HW codecs in ObjC instead of C++ (Closed)

Patch Set: Rebase against https://codereview.webrtc.org/2992233002 Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h ('K') | « webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodecH264.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/UnitTests/objc_video_encoder_factory_tests.mm

diff --git a/webrtc/sdk/objc/Framework/UnitTests/objc_video_encoder_factory_tests.mm b/webrtc/sdk/objc/Framework/UnitTests/objc_video_encoder_factory_tests.mm

index 11fa3fce9df351c7a9f0bc2b1d40382000de9c13..d5941e7abee233d25a50ba71e612560d2042bd0f 100644

--- a/webrtc/sdk/objc/Framework/UnitTests/objc_video_encoder_factory_tests.mm

+++ b/webrtc/sdk/objc/Framework/UnitTests/objc_video_encoder_factory_tests.mm

@@ -29,7 +29,7 @@ id<RTCVideoEncoderFactory> CreateEncoderFactoryReturning(int return_code) {

OCMStub([encoderMock encode:[OCMArg any] codecSpecificInfo:[OCMArg any] frameTypes:[OCMArg any]])

.andReturn(return_code);

OCMStub([encoderMock releaseEncoder]).andReturn(return_code);

- OCMStub([encoderMock setBitrate:0 framerate:0]).andReturn(return_code == WEBRTC_VIDEO_CODEC_OK);

+ OCMStub([encoderMock setBitrate:0 framerate:0]).andReturn(return_code);

id encoderFactoryMock = OCMProtocolMock(@protocol(RTCVideoEncoderFactory));

RTCVideoCodecInfo *supported =