webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm - Issue 2987413002: ObjC: Implement HW codecs in ObjC instead of C++

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm

Issue 2987413002: ObjC: Implement HW codecs in ObjC instead of C++ (Closed)

Patch Set: Rebase against https://codereview.webrtc.org/2992233002 Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h ('K') | « webrtc/sdk/objc/Framework/Classes/VideoToolbox/helpers.cc ('k') | webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm

index f6e6ff55ac1d7a0b422e06272b3149db58f46d23..5a1a51f3f5a515757d14fdf1ca7bfa4ab1f5ffa3 100644

--- a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm

+++ b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm

@@ -33,7 +33,6 @@ class ObjCVideoDecoder : public VideoDecoder {

public:

ObjCVideoDecoder(id<RTCVideoDecoder> decoder)

: decoder_(decoder), implementation_name_([decoder implementationName].stdString) {}

- ~ObjCVideoDecoder() { [decoder_ destroy]; }

int32_t InitDecode(const VideoCodec *codec_settings, int32_t number_of_cores) {

RTCVideoEncoderSettings *settings =