webrtc/modules/rtp_rtcp/source/rtp_utility.cc - Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_utility.cc

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)

Patch Set: Cleanup Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_utility.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_utility.cc b/webrtc/modules/rtp_rtcp/source/rtp_utility.cc

index 4b5ecfa6983d61cba3ebaf9adc74496858c7f4bf..d0870ae315a8ef90447b88deeec01185c1c44e23 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_utility.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_utility.cc

@@ -452,8 +452,7 @@ void RtpHeaderParser::ParseOneByteExtensionHeader(

// | ID | len=0 | Content type |

// +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

- if (ptr[0] <

- static_cast<uint8_t>(VideoContentType::TOTAL_CONTENT_TYPES)) {

+ if (VideoContentTypeHelpers::IsValidContentType(ptr[0])) {

header->extension.hasVideoContentType = true;

header->extension.videoContentType =

static_cast<VideoContentType>(ptr[0]);