webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm - Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)

Patch Set: Remove static initialization from VideoContentType and remove memoization in AlrDetector Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_coding/generic_encoder.cc ('K') | « webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc ('k') | webrtc/system_wrappers/include/metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm b/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm

index 3c39acb38effadb8800c43071859ff6cae8c5250..581098a377eebd96df7462cf2d2c3bc41afcaf4d 100644

--- a/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm

+++ b/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm

@@ -47,7 +47,7 @@

_rotation = encodedImage.rotation_;

_completeFrame = encodedImage._completeFrame;

_qp = encodedImage.qp_ == -1 ? nil : @(encodedImage.qp_);

- _contentType = (encodedImage.content_type_ == webrtc::VideoContentType::SCREENSHARE) ?

+ _contentType = (encodedImage.content_type_ == webrtc::VideoContentType::Screenshare()) ?

RTCVideoContentTypeScreenshare :

RTCVideoContentTypeUnspecified;

}

@@ -72,8 +72,8 @@

encodedImage._completeFrame = _completeFrame;

encodedImage.qp_ = _qp ? _qp.intValue : -1;

encodedImage.content_type_ = (_contentType == RTCVideoContentTypeScreenshare) ?

- webrtc::VideoContentType::SCREENSHARE :

- webrtc::VideoContentType::UNSPECIFIED;

+ webrtc::VideoContentType::Screenshare() :

+ webrtc::VideoContentType::Unspecified();

return encodedImage;

}