webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc - Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)

Patch Set: Remove static initialization from VideoContentType and remove memoization in AlrDetector Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc

index 38450742be9e29022cbabd2245952a88a1b09ddf..4a04491104395aab423bc2eb2b33f241eb7c90ee 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc

@@ -328,7 +328,7 @@ bool RTPSenderVideo::SendVideo(RtpVideoCodecTypes video_type,

last_rotation_ = current_rotation;

// Report content type only for key frames.

if (frame_type == kVideoFrameKey &&

- video_header->content_type != VideoContentType::UNSPECIFIED) {

+ video_header->content_type != VideoContentType::Unspecified()) {

last_packet->SetExtension<VideoContentTypeExtension>(

video_header->content_type);

}