webrtc/video/video_send_stream.cc - Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/video_send_stream.cc

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)

Patch Set: Change nameing style of metrics with simulcast suffixies Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/video/video_send_stream.cc

diff --git a/webrtc/video/video_send_stream.cc b/webrtc/video/video_send_stream.cc

index 9bfc9854f3f979276283a9d8f690ef1c967e717d..cfa7a48453775bd5958aa985026d227bb76e3402 100644

--- a/webrtc/video/video_send_stream.cc

+++ b/webrtc/video/video_send_stream.cc

@@ -858,6 +858,7 @@ VideoSendStreamImpl::VideoSendStreamImpl(

RTC_DCHECK_GE(id, 1);

RTC_DCHECK_LE(id, 14);

RTC_DCHECK(RtpExtension::IsSupportedForVideo(extension));

+ // TODO(ilnik): Remove if statement once experiment is not needed.

if (StringToRtpExtensionType(extension) == kRtpExtensionVideoContentType &&

!field_trial::IsEnabled("WebRTC-VideoContentTypeExtension")) {

continue;