Chromium Code Reviews| Index: webrtc/video/receive_statistics_proxy_unittest.cc |
| diff --git a/webrtc/video/receive_statistics_proxy_unittest.cc b/webrtc/video/receive_statistics_proxy_unittest.cc |
| index 8b3bc0aa7eabfc9ac5c47e5dcf8b40e0eaa0039a..42af56ad1803398653e6d6785fecf15727cf2482 100644 |
| --- a/webrtc/video/receive_statistics_proxy_unittest.cc |
| +++ b/webrtc/video/receive_statistics_proxy_unittest.cc |
| @@ -740,23 +740,20 @@ TEST_P(ReceiveStatisticsProxyTest, InterFrameDelaysAreReported) { |
| (kInterFrameDelayMs * (kMinRequiredSamples - 1) + |
| kInterFrameDelayMs * 2) / |
| kMinRequiredSamples; |
| - switch (content_type) { |
| - case VideoContentType::UNSPECIFIED: |
| - EXPECT_EQ(kExpectedInterFrame, |
| - metrics::MinSample("WebRTC.Video.InterframeDelayInMs")); |
| - EXPECT_EQ(kInterFrameDelayMs * 2, |
| - metrics::MinSample("WebRTC.Video.InterframeDelayMaxInMs")); |
| - break; |
| - case VideoContentType::SCREENSHARE: |
| - EXPECT_EQ( |
| - kExpectedInterFrame, |
| - metrics::MinSample("WebRTC.Video.Screenshare.InterframeDelayInMs")); |
| - EXPECT_EQ(kInterFrameDelayMs * 2, |
| - metrics::MinSample( |
| - "WebRTC.Video.Screenshare.InterframeDelayMaxInMs")); |
| - break; |
| - default: |
| - RTC_NOTREACHED(); |
| + if (content_type == VideoContentType::UNSPECIFIED) { |
| + EXPECT_EQ(kExpectedInterFrame, |
| + metrics::MinSample("WebRTC.Video.InterframeDelayInMs")); |
| + EXPECT_EQ(kInterFrameDelayMs * 2, |
| + metrics::MinSample("WebRTC.Video.InterframeDelayMaxInMs")); |
| + } else if (content_type == VideoContentType::SCREENSHARE) { |
| + EXPECT_EQ( |
| + kExpectedInterFrame, |
| + metrics::MinSample("WebRTC.Video.Screenshare.InterframeDelayInMs")); |
| + EXPECT_EQ( |
| + kInterFrameDelayMs * 2, |
| + metrics::MinSample("WebRTC.Video.Screenshare.InterframeDelayMaxInMs")); |
| + } else { |
| + RTC_NOTREACHED(); |
| } |
|
sprang_webrtc
2017/08/24 09:13:16
Please add tests for stats sliced on layer and exp
ilnik
2017/08/25 12:35:07
Done.
|
| } |