Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Side by Side Diff: webrtc/api/video/video_content_type.h

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)
Patch Set: Implement kwiberg@ comments Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/BUILD.gn ('k') | webrtc/api/video/video_content_type.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_API_VIDEO_VIDEO_CONTENT_TYPE_H_ 11 #ifndef WEBRTC_API_VIDEO_VIDEO_CONTENT_TYPE_H_
12 #define WEBRTC_API_VIDEO_VIDEO_CONTENT_TYPE_H_ 12 #define WEBRTC_API_VIDEO_VIDEO_CONTENT_TYPE_H_
13 13
14 #include <stdint.h> 14 #include <stdint.h>
15 15
16 namespace webrtc { 16 namespace webrtc {
17 17
18 enum class VideoContentType : uint8_t { 18 enum class VideoContentType : uint8_t {
19 UNSPECIFIED = 0, 19 UNSPECIFIED = 0,
20 SCREENSHARE = 1, 20 SCREENSHARE = 1,
21 TOTAL_CONTENT_TYPES // Must be the last value in the enum. 21 };
22
23 struct VideoContentTypeHelpers {
tommi 2017/08/30 09:48:08 nit: should this be a namespace instead of class+s
ilnik 2017/08/30 10:00:56 Done.
24 static bool SetExperimentId(VideoContentType* content_type,
25 uint8_t experiment_id);
26 static bool SetSimulcastId(VideoContentType* content_type,
27 uint8_t simulcast_id);
28
29 static uint8_t GetExperimentId(const VideoContentType& content_type);
30 static uint8_t GetSimulcastId(const VideoContentType& content_type);
31
32 static bool IsScreenshare(const VideoContentType& content_type);
33
34 static bool IsValidContentType(uint8_t value);
22 }; 35 };
23 36
24 } // namespace webrtc 37 } // namespace webrtc
25 38
26 #endif // WEBRTC_API_VIDEO_VIDEO_CONTENT_TYPE_H_ 39 #endif // WEBRTC_API_VIDEO_VIDEO_CONTENT_TYPE_H_
OLDNEW
« no previous file with comments | « webrtc/api/BUILD.gn ('k') | webrtc/api/video/video_content_type.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698