Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_utility.cc

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)
Patch Set: Add metrics sliced on AlrExperiment group Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 if (len != 0) { 445 if (len != 0) {
446 LOG(LS_WARNING) << "Incorrect video content type len: " << len; 446 LOG(LS_WARNING) << "Incorrect video content type len: " << len;
447 return; 447 return;
448 } 448 }
449 // 0 1 449 // 0 1
450 // 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 450 // 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5
451 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ 451 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
452 // | ID | len=0 | Content type | 452 // | ID | len=0 | Content type |
453 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ 453 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
454 454
455 if (ptr[0] < 455 if (VideoContentType::IsValidContentType(ptr[0])) {
456 static_cast<uint8_t>(VideoContentType::TOTAL_CONTENT_TYPES)) {
457 header->extension.hasVideoContentType = true; 456 header->extension.hasVideoContentType = true;
458 header->extension.videoContentType = 457 header->extension.videoContentType = ptr[0];
459 static_cast<VideoContentType>(ptr[0]);
460 } 458 }
461 break; 459 break;
462 } 460 }
463 case kRtpExtensionVideoTiming: { 461 case kRtpExtensionVideoTiming: {
464 if (len != VideoTimingExtension::kValueSizeBytes - 1) { 462 if (len != VideoTimingExtension::kValueSizeBytes - 1) {
465 LOG(LS_WARNING) << "Incorrect video timing len: " << len; 463 LOG(LS_WARNING) << "Incorrect video timing len: " << len;
466 return; 464 return;
467 } 465 }
468 header->extension.has_video_timing = true; 466 header->extension.has_video_timing = true;
469 VideoTimingExtension::Parse(rtc::MakeArrayView(ptr, len + 1), 467 VideoTimingExtension::Parse(rtc::MakeArrayView(ptr, len + 1),
(...skipping 19 matching lines...) Expand all
489 return; 487 return;
490 } 488 }
491 } 489 }
492 } 490 }
493 ptr += (len + 1); 491 ptr += (len + 1);
494 } 492 }
495 } 493 }
496 494
497 } // namespace RtpUtility 495 } // namespace RtpUtility
498 } // namespace webrtc 496 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698