Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Side by Side Diff: webrtc/video/video_send_stream.cc

Issue 2986893002: Piggybacking simulcast id and ALR experiment id into video content type extension. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include "webrtc/video/video_send_stream.h" 10 #include "webrtc/video/video_send_stream.h"
(...skipping 840 matching lines...) Expand 10 before | Expand all | Expand 10 after
851 for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) 851 for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_)
852 transport->packet_router()->AddSendRtpModule(rtp_rtcp); 852 transport->packet_router()->AddSendRtpModule(rtp_rtcp);
853 853
854 for (size_t i = 0; i < config_->rtp.extensions.size(); ++i) { 854 for (size_t i = 0; i < config_->rtp.extensions.size(); ++i) {
855 const std::string& extension = config_->rtp.extensions[i].uri; 855 const std::string& extension = config_->rtp.extensions[i].uri;
856 int id = config_->rtp.extensions[i].id; 856 int id = config_->rtp.extensions[i].id;
857 // One-byte-extension local identifiers are in the range 1-14 inclusive. 857 // One-byte-extension local identifiers are in the range 1-14 inclusive.
858 RTC_DCHECK_GE(id, 1); 858 RTC_DCHECK_GE(id, 1);
859 RTC_DCHECK_LE(id, 14); 859 RTC_DCHECK_LE(id, 14);
860 RTC_DCHECK(RtpExtension::IsSupportedForVideo(extension)); 860 RTC_DCHECK(RtpExtension::IsSupportedForVideo(extension));
861 // TODO(ilnik): Remove if statement once experiment is not needed.
861 if (StringToRtpExtensionType(extension) == kRtpExtensionVideoContentType && 862 if (StringToRtpExtensionType(extension) == kRtpExtensionVideoContentType &&
862 !field_trial::IsEnabled("WebRTC-VideoContentTypeExtension")) { 863 !field_trial::IsEnabled("WebRTC-VideoContentTypeExtension")) {
863 continue; 864 continue;
864 } 865 }
865 for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) { 866 for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
866 RTC_CHECK_EQ(0, rtp_rtcp->RegisterSendRtpHeaderExtension( 867 RTC_CHECK_EQ(0, rtp_rtcp->RegisterSendRtpHeaderExtension(
867 StringToRtpExtensionType(extension), id)); 868 StringToRtpExtensionType(extension), id));
868 } 869 }
869 } 870 }
870 871
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
1370 std::min(config_->rtp.max_packet_size, 1371 std::min(config_->rtp.max_packet_size,
1371 kPathMTU - transport_overhead_bytes_per_packet_); 1372 kPathMTU - transport_overhead_bytes_per_packet_);
1372 1373
1373 for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) { 1374 for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
1374 rtp_rtcp->SetMaxRtpPacketSize(rtp_packet_size); 1375 rtp_rtcp->SetMaxRtpPacketSize(rtp_packet_size);
1375 } 1376 }
1376 } 1377 }
1377 1378
1378 } // namespace internal 1379 } // namespace internal
1379 } // namespace webrtc 1380 } // namespace webrtc
OLDNEW
« webrtc/video/receive_statistics_proxy.cc ('K') | « webrtc/video/receive_statistics_proxy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698