Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe.h

Issue 2986563002: Add probing to recover faster from large bitrate drops. (Closed)
Patch Set: Move drop detection to ProbeController. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/delay_based_bwe.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/congestion_controller/delay_based_bwe.h
diff --git a/webrtc/modules/congestion_controller/delay_based_bwe.h b/webrtc/modules/congestion_controller/delay_based_bwe.h
index 429797af052d3234cb84478aa187241c39fec605..52c227f6725ea920b261f2c508eeaca719d384b6 100644
--- a/webrtc/modules/congestion_controller/delay_based_bwe.h
+++ b/webrtc/modules/congestion_controller/delay_based_bwe.h
@@ -36,12 +36,13 @@ class DelayBasedBwe {
static const int64_t kStreamTimeOutMs = 2000;
struct Result {
- Result() : updated(false), probe(false), target_bitrate_bps(0) {}
- Result(bool probe, uint32_t target_bitrate_bps)
- : updated(true), probe(probe), target_bitrate_bps(target_bitrate_bps) {}
+ Result();
+ Result(bool probe, uint32_t target_bitrate_bps);
+ ~Result();
bool updated;
bool probe;
uint32_t target_bitrate_bps;
+ bool recovered_from_overuse;
};
DelayBasedBwe(RtcEventLog* event_log, const Clock* clock);
@@ -60,9 +61,9 @@ class DelayBasedBwe {
private:
void IncomingPacketFeedback(const PacketFeedback& packet_feedback);
Result OnLongFeedbackDelay(int64_t arrival_time_ms);
-
Result MaybeUpdateEstimate(bool overusing,
- rtc::Optional<uint32_t> acked_bitrate_bps);
+ rtc::Optional<uint32_t> acked_bitrate_bps,
+ bool request_probe);
// Updates the current remote rate estimate and returns true if a valid
// estimate exists.
bool UpdateEstimate(int64_t now_ms,
« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/delay_based_bwe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698