webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc - Issue 2986163002: Audit of kConstants missing the const qualifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc

Issue 2986163002: Audit of kConstants missing the const qualifier (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc

diff --git a/webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc b/webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc

index 44ef82007ba51eaa71318242d96a45b714577502..b724d85356e97a390dd5ed13e8d750f02bc53402 100644

--- a/webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc

+++ b/webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc

@@ -19,7 +19,7 @@

namespace webrtc {

namespace {

-float kMinNoisePower = 100.f;

+const float kMinNoisePower = 100.f;

kwiberg-webrtc 2017/07/31 05:58:29 constexpr?

agrieve 2017/08/08 17:21:28 Done.

} // namespace

NoiseSpectrumEstimator::NoiseSpectrumEstimator(ApmDataDumper* data_dumper)

« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c ('k') | webrtc/modules/pacing/alr_detector.h » ('j') | no next file with comments »