Add PacketRouterTest.Sanity_NoModuleRegistered_*

webrtc/modules/pacing/packet_router_unittest.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 19 matching lines @@
 
 class PacketRouterTest : public ::testing::Test {
  public:
   PacketRouterTest() : packet_router_(new PacketRouter()) {}
  protected:
   static const int kProbeMinProbes = 5;
   static const int kProbeMinBytes = 1000;
   const std::unique_ptr<PacketRouter> packet_router_;
 };
 
+TEST_F(PacketRouterTest, Sanity_NoModuleRegistered_TimeToSendPacket) {
+  PacketRouter packet_router;
+
+  constexpr uint16_t ssrc = 1234;
+  constexpr uint16_t sequence_number = 17;
+  constexpr uint64_t timestamp = 7890;
+  constexpr bool retransmission = false;
+  const PacedPacketInfo paced_info(1, kProbeMinProbes, kProbeMinBytes);
+
+  // TODO(eladalon): TimeToSendPacket() returning true when nothing was

[danilchap, 2017/07/31 08:49:46]

either phrase TODO in a from of what and when should be done.
Or make it a regular comment describing current state of code.

[eladalon, 2017/07/31 08:59:10]

What - still under discussion.
When - next CL (mentioned by the end of the TODO).

[danilchap, 2017/07/31 12:27:34]

Acknowledged.

+  // sent, because no modules were registered, is sub-optimal.
+  // This will be fixed in an upcoming CL.

[danilchap, 2017/07/31 08:49:46]

this line of comment doesn't describe code, so probably better to put it in CL
comment or CL description.

[eladalon, 2017/07/31 08:59:10]

This is still part of the TODO.

+  EXPECT_TRUE(packet_router.TimeToSendPacket(ssrc, sequence_number, timestamp,
+                                             retransmission, paced_info));
+}
+
+TEST_F(PacketRouterTest, Sanity_NoModuleRegistered_TimeToSendPadding) {
+  PacketRouter packet_router;
+
+  constexpr size_t bytes = 300;
+  const PacedPacketInfo paced_info(1, kProbeMinProbes, kProbeMinBytes);
+
+  EXPECT_EQ(packet_router.TimeToSendPadding(bytes, paced_info), 0u);
+}
+
+TEST_F(PacketRouterTest, Sanity_NoModuleRegistered_OnReceiveBitrateChanged) {
+  PacketRouter packet_router;
+
+  const std::vector<uint32_t> ssrcs = {1, 2, 3};
+  constexpr uint32_t bitrate_bps = 10000;
+
+  packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_bps);
+}
+
+TEST_F(PacketRouterTest, Sanity_NoModuleRegistered_SendRemb) {
+  PacketRouter packet_router;
+
+  const std::vector<uint32_t> ssrcs = {1, 2, 3};
+  constexpr uint32_t bitrate_bps = 10000;
+
+  EXPECT_FALSE(packet_router.SendRemb(bitrate_bps, ssrcs));
+}
+
+TEST_F(PacketRouterTest, Sanity_NoModuleRegistered_SendTransportFeedback) {
+  PacketRouter packet_router;
+
+  rtcp::TransportFeedback feedback;
+
+  EXPECT_FALSE(packet_router_->SendTransportFeedback(&feedback));

[danilchap, 2017/07/31 08:49:46]

may be packet_router instead of packet_router_
(i.e. local variable, not the pre-created member variable)

[eladalon, 2017/07/31 08:59:10]

Actually, let me use the one from the fixture. We can probably remove it from
the fixture (in a separate CL, if we choose to do it at all), but until we do,
might as well use it in all of the tests that can.

+}
+
 TEST_F(PacketRouterTest, TimeToSendPacket) {
   NiceMock<MockRtpRtcp> rtp_1;
   NiceMock<MockRtpRtcp> rtp_2;
   packet_router_->AddSendRtpModule(&rtp_1);
   packet_router_->AddSendRtpModule(&rtp_2);
 
   const uint16_t kSsrc1 = 1234;
   uint16_t sequence_number = 17;
   uint64_t timestamp = 7890;
   bool retransmission = false;
@@ skipping 420 matching lines @@
 
   // Lower the estimate to trigger a new packet REMB packet.
   EXPECT_CALL(rtp, SetREMBData(bitrate_estimate - 100, ssrcs)).Times(1);
   packet_router.OnReceiveBitrateChanged(ssrcs, bitrate_estimate - 100);
 
   EXPECT_CALL(rtp, SetREMBStatus(false)).Times(1);
   packet_router.RemoveReceiveRtpModule(&rtp);
 }
 
 }  // namespace webrtc