Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Side by Side Diff: webrtc/modules/video_coding/frame_object.h

Issue 2985283002: Unwrap picture ids in the RtpFrameReferencerFinder. (Closed)
Patch Set: Feedback Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 // been implemented. 42 // been implemented.
43 virtual bool delayed_by_retransmission() const { return 0; } 43 virtual bool delayed_by_retransmission() const { return 0; }
44 44
45 size_t size() const { return _length; } 45 size_t size() const { return _length; }
46 46
47 bool is_keyframe() const { return num_references == 0; } 47 bool is_keyframe() const { return num_references == 0; }
48 48
49 // The tuple (|picture_id|, |spatial_layer|) uniquely identifies a frame 49 // The tuple (|picture_id|, |spatial_layer|) uniquely identifies a frame
50 // object. For codec types that don't necessarily have picture ids they 50 // object. For codec types that don't necessarily have picture ids they
51 // have to be constructed from the header data relevant to that codec. 51 // have to be constructed from the header data relevant to that codec.
52 uint16_t picture_id; 52 int64_t picture_id;
53 uint8_t spatial_layer; 53 uint8_t spatial_layer;
54 uint32_t timestamp; 54 uint32_t timestamp;
55 55
56 // TODO(philipel): Add simple modify/access functions to prevent adding too 56 // TODO(philipel): Add simple modify/access functions to prevent adding too
57 // many |references|. 57 // many |references|.
58 size_t num_references; 58 size_t num_references;
59 uint16_t references[kMaxFrameReferences]; 59 int64_t references[kMaxFrameReferences];
60 bool inter_layer_predicted; 60 bool inter_layer_predicted;
61 }; 61 };
62 62
63 class PacketBuffer; 63 class PacketBuffer;
64 64
65 class RtpFrameObject : public FrameObject { 65 class RtpFrameObject : public FrameObject {
66 public: 66 public:
67 RtpFrameObject(PacketBuffer* packet_buffer, 67 RtpFrameObject(PacketBuffer* packet_buffer,
68 uint16_t first_seq_num, 68 uint16_t first_seq_num,
69 uint16_t last_seq_num, 69 uint16_t last_seq_num,
(...skipping 25 matching lines...) Expand all
95 95
96 // Equal to times nacked of the packet with the highet times nacked 96 // Equal to times nacked of the packet with the highet times nacked
97 // belonging to this frame. 97 // belonging to this frame.
98 int times_nacked_; 98 int times_nacked_;
99 }; 99 };
100 100
101 } // namespace video_coding 101 } // namespace video_coding
102 } // namespace webrtc 102 } // namespace webrtc
103 103
104 #endif // WEBRTC_MODULES_VIDEO_CODING_FRAME_OBJECT_H_ 104 #endif // WEBRTC_MODULES_VIDEO_CODING_FRAME_OBJECT_H_
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/frame_buffer2.cc ('k') | webrtc/modules/video_coding/rtp_frame_reference_finder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698