Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: webrtc/rtc_tools/event_log_visualizer/analyzer.cc

Issue 2983983002: Improved UI for event_log_analyzer tool (Closed)
Patch Set: Rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/rtc_tools/event_log_visualizer/analyzer.h ('k') | webrtc/rtc_tools/event_log_visualizer/main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/rtc_tools/event_log_visualizer/analyzer.cc
diff --git a/webrtc/rtc_tools/event_log_visualizer/analyzer.cc b/webrtc/rtc_tools/event_log_visualizer/analyzer.cc
index b42f0820f48dd878e8263dd03aaf51747769d74b..016176b20977d494d5cbb69dfb6c810d21574592 100644
--- a/webrtc/rtc_tools/event_log_visualizer/analyzer.cc
+++ b/webrtc/rtc_tools/event_log_visualizer/analyzer.cc
@@ -813,7 +813,7 @@ void EventLogAnalyzer::CreateIncomingPacketLossGraph(Plot* plot) {
plot->SetTitle("Estimated incoming loss rate");
}
-void EventLogAnalyzer::CreateDelayChangeGraph(Plot* plot) {
+void EventLogAnalyzer::CreateIncomingDelayDeltaGraph(Plot* plot) {
for (auto& kv : rtp_packets_) {
StreamId stream_id = kv.first;
const std::vector<LoggedRtpPacket>& packet_stream = kv.second;
@@ -843,10 +843,10 @@ void EventLogAnalyzer::CreateDelayChangeGraph(Plot* plot) {
plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin);
plot->SetSuggestedYAxis(0, 1, "Latency change (ms)", kBottomMargin,
kTopMargin);
- plot->SetTitle("Network latency change between consecutive packets");
+ plot->SetTitle("Network latency difference between consecutive packets");
}
-void EventLogAnalyzer::CreateAccumulatedDelayChangeGraph(Plot* plot) {
+void EventLogAnalyzer::CreateIncomingDelayGraph(Plot* plot) {
for (auto& kv : rtp_packets_) {
StreamId stream_id = kv.first;
const std::vector<LoggedRtpPacket>& packet_stream = kv.second;
@@ -876,7 +876,7 @@ void EventLogAnalyzer::CreateAccumulatedDelayChangeGraph(Plot* plot) {
plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin);
plot->SetSuggestedYAxis(0, 1, "Latency change (ms)", kBottomMargin,
kTopMargin);
- plot->SetTitle("Accumulated network latency change");
+ plot->SetTitle("Network latency (relative to first packet)");
}
// Plot the fraction of packets lost (as perceived by the loss-based BWE).
@@ -1408,8 +1408,7 @@ void EventLogAnalyzer::CreateAudioEncoderFrameLengthGraph(Plot* plot) {
plot->SetTitle("Reported audio encoder frame length");
}
-void EventLogAnalyzer::CreateAudioEncoderUplinkPacketLossFractionGraph(
- Plot* plot) {
+void EventLogAnalyzer::CreateAudioEncoderPacketLossGraph(Plot* plot) {
TimeSeries time_series("Audio encoder uplink packet loss fraction",
LINE_DOT_GRAPH);
ProcessPoints<AudioNetworkAdaptationEvent>(
« no previous file with comments | « webrtc/rtc_tools/event_log_visualizer/analyzer.h ('k') | webrtc/rtc_tools/event_log_visualizer/main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698