Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: webrtc/stats/rtcstatsreport.cc

Issue 2983243002: Make RTCStatsReport::ToString() return JSON-parseable string. (Closed)
Patch Set: Add test. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 100
101 RTCStatsReport::ConstIterator RTCStatsReport::end() const { 101 RTCStatsReport::ConstIterator RTCStatsReport::end() const {
102 return ConstIterator(rtc::scoped_refptr<const RTCStatsReport>(this), 102 return ConstIterator(rtc::scoped_refptr<const RTCStatsReport>(this),
103 stats_.cend()); 103 stats_.cend());
104 } 104 }
105 105
106 std::string RTCStatsReport::ToString() const { 106 std::string RTCStatsReport::ToString() const {
107 std::ostringstream oss; 107 std::ostringstream oss;
108 ConstIterator it = begin(); 108 ConstIterator it = begin();
109 if (it != end()) { 109 if (it != end()) {
110 oss << it->ToString(); 110 oss << '[' << it->ToString();
111 for (++it; it != end(); ++it) { 111 for (++it; it != end(); ++it) {
112 oss << '\n' << it->ToString(); 112 oss << ",\n" << it->ToString();
113 } 113 }
114 oss << ']';
hbos 2017/07/25 12:29:21 Is it valid JSON to have just an array, and not a
114 } 115 }
115 return oss.str(); 116 return oss.str();
116 } 117 }
117 118
118 } // namespace webrtc 119 } // namespace webrtc
OLDNEW
« webrtc/stats/rtcstats_unittest.cc ('K') | « webrtc/stats/rtcstats_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698