Make RTCStatsReport::ToString() return JSON-parseable string.

webrtc/stats/rtcstats.cc

 /*
  *  Copyright 2016 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/api/stats/rtcstats.h"
 
 #include <sstream>
 
 #include "webrtc/rtc_base/stringencode.h"
 
 namespace webrtc {
 
 namespace {
 
-// Produces "{ a, b, c }". Works for non-vector |RTCStatsMemberInterface::Type|
+// Produces "[ a, b, c ]". Works for non-vector |RTCStatsMemberInterface::Type|
 // types.
 template<typename T>
 std::string VectorToString(const std::vector<T>& vector) {
   if (vector.empty())
-    return "{}";
+    return "[]";
   std::ostringstream oss;
-  oss << "{ " << rtc::ToString<T>(vector[0]);
+  oss << "[ " << rtc::ToString<T>(vector[0]);
   for (size_t i = 1; i < vector.size(); ++i) {
     oss << ", " << rtc::ToString<T>(vector[i]);
   }
-  oss << " }";
+  oss << " ]";
   return oss.str();
 }
 
-// Produces "{ \"a\", \"b\", \"c\" }". Works for vectors of both const char* and
+// Produces "[ \"a\", \"b\", \"c\" ]". Works for vectors of both const char* and
 // std::string element types.
 template<typename T>
 std::string VectorOfStringsToString(const std::vector<T>& strings) {
   if (strings.empty())
-    return "{}";
+    return "[]";
   std::ostringstream oss;
-  oss << "{ \"" << rtc::ToString<T>(strings[0]) << '\"';
+  oss << "[ \"" << rtc::ToString<T>(strings[0]) << '\"';
   for (size_t i = 1; i < strings.size(); ++i) {
     oss << ", \"" << rtc::ToString<T>(strings[i]) << '\"';
   }
-  oss << " }";
+  oss << " ]";
   return oss.str();
 }
 
 }  // namespace
 
 bool RTCStats::operator==(const RTCStats& other) const {
   if (type() != other.type() || id() != other.id())
     return false;
   std::vector<const RTCStatsMemberInterface*> members = Members();
   std::vector<const RTCStatsMemberInterface*> other_members = other.Members();
   RTC_DCHECK_EQ(members.size(), other_members.size());
   for (size_t i = 0; i < members.size(); ++i) {
     const RTCStatsMemberInterface* member = members[i];
     const RTCStatsMemberInterface* other_member = other_members[i];
     RTC_DCHECK_EQ(member->type(), other_member->type());
     RTC_DCHECK_EQ(member->name(), other_member->name());
     if (*member != *other_member)
       return false;
   }
   return true;
 }
 
 bool RTCStats::operator!=(const RTCStats& other) const {
   return !(*this == other);
 }
 
 std::string RTCStats::ToString() const {
   std::ostringstream oss;
-  oss << type() << " {\n  id: \"" << id_ << "\"\n  timestamp: "
-      << timestamp_us_ << '\n';
+  oss << "{\n  \"type\": \"" << type() << "\",\n  \"id\": \"" << id_
+      << "\",\n  \"timestamp\": " << timestamp_us_;
   for (const RTCStatsMemberInterface* member : Members()) {
-    oss << "  " << member->name() << ": ";
     if (member->is_defined()) {
+      oss << ",\n  \"" << member->name() << "\": ";
       if (member->is_string())
-        oss << '"' << member->ValueToString() << "\"\n";
+        oss << '"' << member->ValueToString() << '"';
       else
-        oss << member->ValueToString() << '\n';
-    } else {
-      oss << "undefined\n";
+        oss << member->ValueToString();
     }
   }
-  oss << '}';
+  oss << "\n}";
   return oss.str();
 }
 
 std::vector<const RTCStatsMemberInterface*> RTCStats::Members() const {
   return MembersOfThisObjectAndAncestors(0);
 }
 
 std::vector<const RTCStatsMemberInterface*>
 RTCStats::MembersOfThisObjectAndAncestors(
     size_t additional_capacity) const {
@@ skipping 46 matching lines @@
     std::vector<uint64_t>, kSequenceUint64, true, false,
     VectorToString(value_));
 WEBRTC_DEFINE_RTCSTATSMEMBER(
     std::vector<double>, kSequenceDouble, true, false,
     VectorToString(value_));
 WEBRTC_DEFINE_RTCSTATSMEMBER(
     std::vector<std::string>, kSequenceString, true, false,
     VectorOfStringsToString(value_));
 
 }  // namespace webrtc