Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: webrtc/pc/rtcstats_integrationtest.cc

Issue 2983243002: Make RTCStatsReport::ToString() return JSON-parseable string. (Closed)
Patch Set: Replace ToString with ToJson in test files. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/stats/rtcstatsreport.h ('k') | webrtc/pc/rtcstatscollector_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 318 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 } 329 }
330 } 330 }
331 if (!missing_stats.empty()) { 331 if (!missing_stats.empty()) {
332 verify_successful = false; 332 verify_successful = false;
333 for (const char* missing : missing_stats) { 333 for (const char* missing : missing_stats) {
334 EXPECT_TRUE(false) << "Missing expected stats type: " << missing; 334 EXPECT_TRUE(false) << "Missing expected stats type: " << missing;
335 } 335 }
336 } 336 }
337 EXPECT_TRUE(verify_successful) << 337 EXPECT_TRUE(verify_successful) <<
338 "One or more problems with the stats. This is the report:\n" << 338 "One or more problems with the stats. This is the report:\n" <<
339 report_->ToString(); 339 report_->ToJson();
340 } 340 }
341 341
342 bool VerifyRTCCertificateStats( 342 bool VerifyRTCCertificateStats(
343 const RTCCertificateStats& certificate) { 343 const RTCCertificateStats& certificate) {
344 RTCStatsVerifier verifier(report_, &certificate); 344 RTCStatsVerifier verifier(report_, &certificate);
345 verifier.TestMemberIsDefined(certificate.fingerprint); 345 verifier.TestMemberIsDefined(certificate.fingerprint);
346 verifier.TestMemberIsDefined(certificate.fingerprint_algorithm); 346 verifier.TestMemberIsDefined(certificate.fingerprint_algorithm);
347 verifier.TestMemberIsDefined(certificate.base64_certificate); 347 verifier.TestMemberIsDefined(certificate.base64_certificate);
348 verifier.TestMemberIsOptionalIDReference( 348 verifier.TestMemberIsOptionalIDReference(
349 certificate.issuer_certificate_id, RTCCertificateStats::kType); 349 certificate.issuer_certificate_id, RTCCertificateStats::kType);
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
669 caller_ = nullptr; 669 caller_ = nullptr;
670 // Any pending stats requests should have completed in the act of destroying 670 // Any pending stats requests should have completed in the act of destroying
671 // the peer connection. 671 // the peer connection.
672 EXPECT_TRUE(stats_obtainer->report()); 672 EXPECT_TRUE(stats_obtainer->report());
673 } 673 }
674 #endif // HAVE_SCTP 674 #endif // HAVE_SCTP
675 675
676 } // namespace 676 } // namespace
677 677
678 } // namespace webrtc 678 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/api/stats/rtcstatsreport.h ('k') | webrtc/pc/rtcstatscollector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698