Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: webrtc/pc/rtcstats_integrationtest.cc

Issue 2981623002: Make the default ctor of rtc::Thread, protected (Closed)
Patch Set: Format Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/proxy_unittest.cc ('k') | webrtc/pc/test/fakeaudiocapturemodule.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/rtcstats_integrationtest.cc
diff --git a/webrtc/pc/rtcstats_integrationtest.cc b/webrtc/pc/rtcstats_integrationtest.cc
index 3d1e7d66ea50fe947d25aa7b3c709df3ca3badc6..3dffb8d7139257d3af0774ab8196b065c9b0ad52 100644
--- a/webrtc/pc/rtcstats_integrationtest.cc
+++ b/webrtc/pc/rtcstats_integrationtest.cc
@@ -34,14 +34,15 @@ const int64_t kGetStatsTimeoutMs = 10000;
class RTCStatsIntegrationTest : public testing::Test {
public:
RTCStatsIntegrationTest()
- : network_thread_(&virtual_socket_server_), worker_thread_() {
- RTC_CHECK(network_thread_.Start());
- RTC_CHECK(worker_thread_.Start());
+ : network_thread_(new rtc::Thread(&virtual_socket_server_)),
+ worker_thread_(rtc::Thread::Create()) {
+ RTC_CHECK(network_thread_->Start());
+ RTC_CHECK(worker_thread_->Start());
caller_ = new rtc::RefCountedObject<PeerConnectionTestWrapper>(
- "caller", &network_thread_, &worker_thread_);
+ "caller", network_thread_.get(), worker_thread_.get());
callee_ = new rtc::RefCountedObject<PeerConnectionTestWrapper>(
- "callee", &network_thread_, &worker_thread_);
+ "callee", network_thread_.get(), worker_thread_.get());
}
void StartCall() {
@@ -96,8 +97,8 @@ class RTCStatsIntegrationTest : public testing::Test {
// |network_thread_| uses |virtual_socket_server_| so they must be
// constructed/destructed in the correct order.
rtc::VirtualSocketServer virtual_socket_server_;
- rtc::Thread network_thread_;
- rtc::Thread worker_thread_;
+ std::unique_ptr<rtc::Thread> network_thread_;
+ std::unique_ptr<rtc::Thread> worker_thread_;
rtc::scoped_refptr<PeerConnectionTestWrapper> caller_;
rtc::scoped_refptr<PeerConnectionTestWrapper> callee_;
};
« no previous file with comments | « webrtc/pc/proxy_unittest.cc ('k') | webrtc/pc/test/fakeaudiocapturemodule.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698