Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2010)

Unified Diff: webrtc/pc/rtptransport.cc

Issue 2981513002: Wire up RTP keep-alive in ortc api. (Closed)
Patch Set: deps, again Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/rtptransport.h ('k') | webrtc/pc/rtptransport_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/rtptransport.cc
diff --git a/webrtc/pc/rtptransport.cc b/webrtc/pc/rtptransport.cc
index 8a524dd07a3ab177ca95fb547c9e80adb7727ac7..ac57eb887bc690c3fadd8bd793c24ba3629245f8 100644
--- a/webrtc/pc/rtptransport.cc
+++ b/webrtc/pc/rtptransport.cc
@@ -115,24 +115,30 @@ PacketTransportInterface* RtpTransport::GetRtcpPacketTransport() const {
return rtcp_packet_transport_;
}
-RTCError RtpTransport::SetRtcpParameters(const RtcpParameters& parameters) {
- if (rtcp_parameters_.mux && !parameters.mux) {
+RTCError RtpTransport::SetParameters(const RtpTransportParameters& parameters) {
+ if (parameters_.rtcp.mux && !parameters.rtcp.mux) {
LOG_AND_RETURN_ERROR(RTCErrorType::INVALID_STATE,
"Disabling RTCP muxing is not allowed.");
}
+ if (parameters.keepalive != parameters_.keepalive) {
+ // TODO(sprang): Wire up support for keep-alive (only ORTC support for now).
+ LOG_AND_RETURN_ERROR(
+ RTCErrorType::INVALID_MODIFICATION,
+ "RTP keep-alive parameters not supported by this channel.");
+ }
- RtcpParameters new_parameters = parameters;
+ RtpTransportParameters new_parameters = parameters;
- if (new_parameters.cname.empty()) {
- new_parameters.cname = rtcp_parameters_.cname;
+ if (new_parameters.rtcp.cname.empty()) {
+ new_parameters.rtcp.cname = parameters_.rtcp.cname;
}
- rtcp_parameters_ = new_parameters;
+ parameters_ = new_parameters;
return RTCError::OK();
}
-RtcpParameters RtpTransport::GetRtcpParameters() const {
- return rtcp_parameters_;
+RtpTransportParameters RtpTransport::GetParameters() const {
+ return parameters_;
}
RtpTransportAdapter* RtpTransport::GetInternal() {
« no previous file with comments | « webrtc/pc/rtptransport.h ('k') | webrtc/pc/rtptransport_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698