Wire up RTP keep-alive in ortc api.

webrtc/ortc/ortcfactory.h

Index: webrtc/ortc/ortcfactory.h
diff --git a/webrtc/ortc/ortcfactory.h b/webrtc/ortc/ortcfactory.h
index 2ce7be39cce708767db9b776e324461f64acd930..9f2f39aa59557e9d8fc674053af791aad003de6c 100644
--- a/webrtc/ortc/ortcfactory.h
+++ b/webrtc/ortc/ortcfactory.h
@@ -43,14 +43,17 @@ class OrtcFactory : public OrtcFactoryInterface {
   RTCErrorOr<std::unique_ptr<RtpTransportControllerInterface>>
   CreateRtpTransportController() override;
 
+  RTCErrorOr<std::unique_ptr<RtpTransportControllerInterface>>
+  CreateRtpTransportController(const RtpTransportParameters& parameters);

[Taylor Brandstetter, 2017/08/03 01:18:03]

We shouldn't add this method; the fact that RtpTransportControllerAdapter knows
about RtpTransportParameters is an implementation detail. From an API
perspective, each RtpTransport has its own RtpTransportParameters, just like how
each RtpSender/RtpReceiver has its own RtpParameters.

[sprang_webrtc, 2017/08/03 13:08:14]

True, that's why I didn't add it to the interface. What if we just make it
private? I did this since it allows setting the call config on construction.

[Taylor Brandstetter, 2017/08/03 16:50:36]

I don't see that allowing setting the call config on construction buys much,
since you need to be able to set it after construction anyway, in the normal
case where the RtpTransport is created after the RtpTransportController. I also
can't find where this constructor is called (or even defined).

+
   RTCErrorOr<std::unique_ptr<RtpTransportInterface>> CreateRtpTransport(
-      const RtcpParameters& rtcp_parameters,
+      const RtpTransportParameters& parameters,
       PacketTransportInterface* rtp,
       PacketTransportInterface* rtcp,
       RtpTransportControllerInterface* transport_controller) override;
 
   RTCErrorOr<std::unique_ptr<SrtpTransportInterface>> CreateSrtpTransport(
-      const RtcpParameters& rtcp_parameters,
+      const RtpTransportParameters& parameters,
       PacketTransportInterface* rtp,
       PacketTransportInterface* rtcp,
       RtpTransportControllerInterface* transport_controller) override;