Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Side by Side Diff: webrtc/pc/rtptransport_unittest.cc

Issue 2981513002: Wire up RTP keep-alive in ortc api. (Closed)
Patch Set: Moved RtcpParameters into RtpTransportParameters Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include <string> 11 #include <string>
12 12
13 #include "webrtc/p2p/base/fakepackettransport.h" 13 #include "webrtc/p2p/base/fakepackettransport.h"
14 #include "webrtc/pc/rtptransport.h" 14 #include "webrtc/pc/rtptransport.h"
15 #include "webrtc/rtc_base/gunit.h" 15 #include "webrtc/rtc_base/gunit.h"
16 16
17 namespace webrtc { 17 namespace webrtc {
18 18
19 constexpr bool kMuxDisabled = false; 19 constexpr bool kMuxDisabled = false;
20 constexpr bool kMuxEnabled = true; 20 constexpr bool kMuxEnabled = true;
21 21
22 TEST(RtpTransportTest, SetRtcpParametersCantDisableRtcpMux) { 22 TEST(RtpTransportTest, SetRtcpParametersCantDisableRtcpMux) {
23 RtpTransport transport(kMuxDisabled); 23 RtpTransport transport(kMuxDisabled);
24 RtcpParameters params; 24 RtpTransportParameters params;
25 transport.SetRtcpParameters(params); 25 transport.SetParameters(params);
26 params.mux = false; 26 params.rtcp.mux = false;
27 EXPECT_FALSE(transport.SetRtcpParameters(params).ok()); 27 EXPECT_FALSE(transport.SetParameters(params).ok());
28 } 28 }
29 29
30 TEST(RtpTransportTest, SetRtcpParametersEmptyCnameUsesExisting) { 30 TEST(RtpTransportTest, SetRtcpParametersEmptyCnameUsesExisting) {
31 static const char kName[] = "name"; 31 static const char kName[] = "name";
32 RtpTransport transport(kMuxDisabled); 32 RtpTransport transport(kMuxDisabled);
33 RtcpParameters params_with_name; 33 RtpTransportParameters params_with_name;
34 params_with_name.cname = kName; 34 params_with_name.rtcp.cname = kName;
35 transport.SetRtcpParameters(params_with_name); 35 transport.SetParameters(params_with_name);
36 EXPECT_EQ(transport.GetRtcpParameters().cname, kName); 36 EXPECT_EQ(transport.GetParameters().rtcp.cname, kName);
37 37
38 RtcpParameters params_without_name; 38 RtpTransportParameters params_without_name;
39 transport.SetRtcpParameters(params_without_name); 39 transport.SetParameters(params_without_name);
40 EXPECT_EQ(transport.GetRtcpParameters().cname, kName); 40 EXPECT_EQ(transport.GetParameters().rtcp.cname, kName);
41 } 41 }
42 42
43 class SignalObserver : public sigslot::has_slots<> { 43 class SignalObserver : public sigslot::has_slots<> {
44 public: 44 public:
45 explicit SignalObserver(RtpTransport* transport) { 45 explicit SignalObserver(RtpTransport* transport) {
46 transport->SignalReadyToSend.connect(this, &SignalObserver::OnReadyToSend); 46 transport->SignalReadyToSend.connect(this, &SignalObserver::OnReadyToSend);
47 } 47 }
48 bool ready() const { return ready_; } 48 bool ready() const { return ready_; }
49 void OnReadyToSend(bool ready) { ready_ = ready; } 49 void OnReadyToSend(bool ready) { ready_ = ready; }
50 50
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 227
228 const rtc::PacketOptions options; 228 const rtc::PacketOptions options;
229 const int flags = 0; 229 const int flags = 0;
230 rtc::Buffer rtp_data(kRtpData, kRtpLen); 230 rtc::Buffer rtp_data(kRtpData, kRtpLen);
231 fake_rtp.SendPacket(rtp_data.data<char>(), kRtpLen, options, flags); 231 fake_rtp.SendPacket(rtp_data.data<char>(), kRtpLen, options, flags);
232 EXPECT_EQ(0, observer.rtp_count()); 232 EXPECT_EQ(0, observer.rtp_count());
233 EXPECT_EQ(0, observer.rtcp_count()); 233 EXPECT_EQ(0, observer.rtcp_count());
234 } 234 }
235 235
236 } // namespace webrtc 236 } // namespace webrtc
OLDNEW
« webrtc/ortc/rtptransportcontrolleradapter.h ('K') | « webrtc/pc/rtptransport.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698