Wire up RTP keep-alive in ortc api.

webrtc/pc/rtptransport_unittest.cc

 /*
  *  Copyright 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <string>
 
 #include "webrtc/p2p/base/fakepackettransport.h"
 #include "webrtc/pc/rtptransport.h"
 #include "webrtc/pc/rtptransporttestutil.h"
 #include "webrtc/rtc_base/gunit.h"
 
 namespace webrtc {
 
 constexpr bool kMuxDisabled = false;
 constexpr bool kMuxEnabled = true;
 
 TEST(RtpTransportTest, SetRtcpParametersCantDisableRtcpMux) {
   RtpTransport transport(kMuxDisabled);
-  RtcpParameters params;
-  transport.SetRtcpParameters(params);
-  params.mux = false;
-  EXPECT_FALSE(transport.SetRtcpParameters(params).ok());
+  RtpTransportParameters params;
+  transport.SetParameters(params);
+  params.rtcp.mux = false;
+  EXPECT_FALSE(transport.SetParameters(params).ok());
 }
 
 TEST(RtpTransportTest, SetRtcpParametersEmptyCnameUsesExisting) {
   static const char kName[] = "name";
   RtpTransport transport(kMuxDisabled);
-  RtcpParameters params_with_name;
-  params_with_name.cname = kName;
-  transport.SetRtcpParameters(params_with_name);
-  EXPECT_EQ(transport.GetRtcpParameters().cname, kName);
+  RtpTransportParameters params_with_name;
+  params_with_name.rtcp.cname = kName;
+  transport.SetParameters(params_with_name);
+  EXPECT_EQ(transport.GetParameters().rtcp.cname, kName);
 
-  RtcpParameters params_without_name;
-  transport.SetRtcpParameters(params_without_name);
-  EXPECT_EQ(transport.GetRtcpParameters().cname, kName);
+  RtpTransportParameters params_without_name;
+  transport.SetParameters(params_without_name);
+  EXPECT_EQ(transport.GetParameters().rtcp.cname, kName);
+}
+
+TEST(RtpTransportTest, SetRtpTransportKeepAliveNotSupported) {

[Taylor Brandstetter, 2017/08/03 01:18:04]

Can you add a comment explaining that this is a limitation of the current
implementation, and may be fixed later?

[sprang_webrtc, 2017/08/03 13:08:14]

Done.

+  RtpTransport transport(kMuxDisabled);
+  RtpTransportParameters params;
+  params.keepalive.timeout_interval_ms = 1;
+  auto result = transport.SetParameters(params);
+  EXPECT_FALSE(result.ok());
+  EXPECT_EQ(RTCErrorType::INVALID_MODIFICATION, result.type());
 }
 
 class SignalObserver : public sigslot::has_slots<> {
  public:
   explicit SignalObserver(RtpTransport* transport) {
     transport->SignalReadyToSend.connect(this, &SignalObserver::OnReadyToSend);
   }
   bool ready() const { return ready_; }
   void OnReadyToSend(bool ready) { ready_ = ready; }
 
@@ skipping 153 matching lines @@
 
   const rtc::PacketOptions options;
   const int flags = 0;
   rtc::Buffer rtp_data(kRtpData, kRtpLen);
   fake_rtp.SendPacket(rtp_data.data<char>(), kRtpLen, options, flags);
   EXPECT_EQ(0, observer.rtp_count());
   EXPECT_EQ(0, observer.rtcp_count());
 }
 
 }  // namespace webrtc