Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc

Issue 2980943003: RtpFrameReferenceFinder VP8 reference calculation fix. (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/rtp_frame_reference_finder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
diff --git a/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc b/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
index b4c30a96e31a1bac863b81a8038ccf4360b871b2..c75c45eb0fa823602409549892dadf4c591cc62a 100644
--- a/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
+++ b/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
@@ -671,6 +671,31 @@ TEST_F(TestRtpFrameReferenceFinder, Vp8Tl1SyncFrameAfterTl1Frame) {
CheckReferencesVp8(5, 3);
}
+TEST_F(TestRtpFrameReferenceFinder, Vp8DetectMissingFrame_0212) {
+ InsertVp8(1, 1, true, 1, 0, 1, false);
+ InsertVp8(2, 2, false, 2, 2, 1, true);
+ InsertVp8(3, 3, false, 3, 1, 1, true);
+ InsertVp8(4, 4, false, 4, 2, 1, false);
+
+ InsertVp8(6, 6, false, 6, 2, 2, false);
+ InsertVp8(7, 7, false, 7, 1, 2, false);
+ InsertVp8(8, 8, false, 8, 2, 2, false);
+ ASSERT_EQ(4UL, frames_from_callback_.size());
+
+ InsertVp8(5, 5, false, 5, 0, 2, false);
+ ASSERT_EQ(8UL, frames_from_callback_.size());
+
+ CheckReferencesVp8(1);
+ CheckReferencesVp8(2, 1);
+ CheckReferencesVp8(3, 1);
+ CheckReferencesVp8(4, 3, 2, 1);
+
+ CheckReferencesVp8(5, 1);
+ CheckReferencesVp8(6, 5, 4, 3);
+ CheckReferencesVp8(7, 5, 3);
+ CheckReferencesVp8(8, 7, 6, 5);
+}
+
TEST_F(TestRtpFrameReferenceFinder, Vp9GofInsertOneFrame) {
uint16_t pid = Rand();
uint16_t sn = Rand();
« no previous file with comments | « webrtc/modules/video_coding/rtp_frame_reference_finder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698