Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Side by Side Diff: webrtc/modules/video_coding/frame_buffer2.h

Issue 2980413002: Fix the video buffer size should take rtt into consideration (Closed)
Patch Set: MODIFY address small redesign issues from the comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 void SetProtectionMode(VCMVideoProtection mode); 66 void SetProtectionMode(VCMVideoProtection mode);
67 67
68 // Start the frame buffer, has no effect if the frame buffer is started. 68 // Start the frame buffer, has no effect if the frame buffer is started.
69 // The frame buffer is started upon construction. 69 // The frame buffer is started upon construction.
70 void Start(); 70 void Start();
71 71
72 // Stop the frame buffer, causing any sleeping thread in NextFrame to 72 // Stop the frame buffer, causing any sleeping thread in NextFrame to
73 // return immediately. 73 // return immediately.
74 void Stop(); 74 void Stop();
75 75
76 // Updates the RTT for jitter buffer estimation.
philipel 2017/07/28 16:11:44 Just comment with "Updates the RTT for jitter buff
77 //
78 // Input:
79 // - rttMs : RTT in ms
80 void UpdateRtt(int64_t rttMs);
philipel 2017/07/28 16:11:44 rttMs --> rtt_ms
81
76 private: 82 private:
77 struct FrameKey { 83 struct FrameKey {
78 FrameKey() : picture_id(0), spatial_layer(0) {} 84 FrameKey() : picture_id(0), spatial_layer(0) {}
79 FrameKey(uint16_t picture_id, uint8_t spatial_layer) 85 FrameKey(uint16_t picture_id, uint8_t spatial_layer)
80 : picture_id(picture_id), spatial_layer(spatial_layer) {} 86 : picture_id(picture_id), spatial_layer(spatial_layer) {}
81 87
82 bool operator<(const FrameKey& rhs) const { 88 bool operator<(const FrameKey& rhs) const {
83 if (picture_id == rhs.picture_id) 89 if (picture_id == rhs.picture_id)
84 return spatial_layer < rhs.spatial_layer; 90 return spatial_layer < rhs.spatial_layer;
85 return AheadOf(rhs.picture_id, picture_id); 91 return AheadOf(rhs.picture_id, picture_id);
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 VCMReceiveStatisticsCallback* const stats_callback_; 185 VCMReceiveStatisticsCallback* const stats_callback_;
180 int64_t last_log_non_decoded_ms_ GUARDED_BY(crit_); 186 int64_t last_log_non_decoded_ms_ GUARDED_BY(crit_);
181 187
182 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(FrameBuffer); 188 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(FrameBuffer);
183 }; 189 };
184 190
185 } // namespace video_coding 191 } // namespace video_coding
186 } // namespace webrtc 192 } // namespace webrtc
187 193
188 #endif // WEBRTC_MODULES_VIDEO_CODING_FRAME_BUFFER2_H_ 194 #endif // WEBRTC_MODULES_VIDEO_CODING_FRAME_BUFFER2_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698