Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc

Issue 2979413002: Refactor composing report blocks for rtcp Sender/Receiver reports (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc
index 59c08c3c66ef093761f7f32fab79a3efaf2720f4..2624a6a2d4b1d1325c7f94a6ce1e4530c429ccdc 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc
@@ -10,6 +10,8 @@
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h"
+#include <utility>
+
#include "webrtc/modules/rtp_rtcp/source/byte_io.h"
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h"
#include "webrtc/rtc_base/checks.h"
@@ -122,5 +124,14 @@ bool SenderReport::AddReportBlock(const ReportBlock& block) {
return true;
}
+bool SenderReport::SetReportBlocks(std::vector<ReportBlock> blocks) {
eladalon 2017/07/21 12:53:19 Similar comments for this file and the next one as
danilchap 2017/07/21 17:11:14 Done.
+ if (blocks.size() > kMaxNumberOfReportBlocks) {
+ LOG(LS_WARNING) << "Max report blocks reached.";
+ return false;
+ }
+ report_blocks_ = std::move(blocks);
+ return true;
+}
+
} // namespace rtcp
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698