Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc

Issue 2979413002: Refactor composing report blocks for rtcp Sender/Receiver reports (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 const size_t kMaxReportBlocks = (1 << 5) - 1; 104 const size_t kMaxReportBlocks = (1 << 5) - 1;
105 ReportBlock rb; 105 ReportBlock rb;
106 for (size_t i = 0; i < kMaxReportBlocks; ++i) { 106 for (size_t i = 0; i < kMaxReportBlocks; ++i) {
107 rb.SetMediaSsrc(kRemoteSsrc + i); 107 rb.SetMediaSsrc(kRemoteSsrc + i);
108 EXPECT_TRUE(sr.AddReportBlock(rb)); 108 EXPECT_TRUE(sr.AddReportBlock(rb));
109 } 109 }
110 rb.SetMediaSsrc(kRemoteSsrc + kMaxReportBlocks); 110 rb.SetMediaSsrc(kRemoteSsrc + kMaxReportBlocks);
111 EXPECT_FALSE(sr.AddReportBlock(rb)); 111 EXPECT_FALSE(sr.AddReportBlock(rb));
112 } 112 }
113 113
114 TEST(RtcpPacketSenderReportTest, SetReportBlocksOverwritesOldBlocks) {
115 SenderReport sr;
116 sr.AddReportBlock(ReportBlock());
117 ASSERT_EQ(sr.report_blocks().size(), 1u);
118
119 std::vector<ReportBlock> blocks(3);
120 EXPECT_TRUE(sr.SetReportBlocks(blocks));
121 EXPECT_EQ(sr.report_blocks().size(), 3u);
122 }
123
124 TEST(RtcpPacketSenderReportTest, SetTooManyReportBlocks) {
125 SenderReport sr;
126 const size_t kMaxReportBlocks = (1 << 5) - 1;
127
128 std::vector<ReportBlock> blocks(kMaxReportBlocks);
129 EXPECT_TRUE(sr.SetReportBlocks(blocks));
130
131 blocks.push_back(ReportBlock());
132 EXPECT_FALSE(sr.SetReportBlocks(blocks));
133 }
134
114 } // namespace webrtc 135 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698